Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2722953003: Part 1 to rename platform/Widget to platform/FrameViewBase. (Closed)

Created:
3 years, 9 months ago by joelhockey
Modified:
3 years, 9 months ago
Reviewers:
haraken, slangley, sashab
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Part 1 to rename platform/Widget to platform/FrameViewBase. Rename Widget to FrameViewBase but leave 'using Widget = FrameViewBase' in Widget.h. Minimum other changes made to other classes that are using forward declarations. Following CLs will change clients from importing and using Widget.h to use FrameViewBase.h BUG=697351 Review-Url: https://codereview.chromium.org/2722953003 Cr-Commit-Position: refs/heads/master@{#453894} Committed: https://chromium.googlesource.com/chromium/src/+/77d29a88d7a2292838afe8bbd0a48fb2546fc484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -355 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptController.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrameClient.h View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/PluginDocument.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/FrameViewBase.h View 5 chunks +17 lines, -17 lines 0 comments Download
A + third_party/WebKit/Source/platform/FrameViewBase.cpp View 2 chunks +40 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/platform/HostWindow.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/Widget.h View 1 chunk +4 lines, -100 lines 0 comments Download
D third_party/WebKit/Source/platform/Widget.cpp View 1 chunk +0 lines, -159 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeClient.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.h View 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
joelhockey
3 years, 9 months ago (2017-03-01 07:05:02 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-01 07:07:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722953003/1
3 years, 9 months ago (2017-03-01 08:51:10 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 09:26:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77d29a88d7a2292838afe8bbd0a4...

Powered by Google App Engine
This is Rietveld 408576698