Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2722953002: Revert of [sync] Add Sessions integration tests (Closed)

Created:
3 years, 9 months ago by Sergey Ulanov
Modified:
3 years, 9 months ago
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [sync] Add Sessions integration tests (patchset #4 id:140001 of https://codereview.chromium.org/2713913002/ ) Reason for revert: SingleClientSessionsSyncTest.CookieJarMismatch fails on mac: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/37124 Original issue's description: > [sync] Add Sessions integration tests > > Add integration tests for a number of new scenarios: > * Multi window, multi tab > * Navigation hierarchy changes > * Tab movement > > Add a new checker for waiting to see a SessionsHierarchy on > the FakeServer. Refactor some existing tests to use this instead of > waiting for sync cycle completion then manually verifying a match. > > Add several new helper methods to SessionsHelper, and refactor some > existing ones. > > Add the ability to open a new Browser from an existing Profile > to SyncTest. > > R=zea@chromium.org, skym@chromium.org > > BUG=695241 > > Review-Url: https://codereview.chromium.org/2713913002 > Cr-Commit-Position: refs/heads/master@{#453687} > Committed: https://chromium.googlesource.com/chromium/src/+/dd0356002ee91f25daa99dd147c57913517e9aab TBR=zea@chromium.org,skym@chromium.org,pnoland@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=695241 Review-Url: https://codereview.chromium.org/2722953002 Cr-Commit-Position: refs/heads/master@{#453773} Committed: https://chromium.googlesource.com/chromium/src/+/aa1ab1dc32ed1b5508c7b835085a503ea8d96280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -445 lines) Patch
D chrome/browser/sync/test/integration/session_hierarchy_match_checker.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/sync/test/integration/session_hierarchy_match_checker.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/sync/test/integration/sessions_helper.h View 2 chunks +17 lines, -28 lines 0 comments Download
M chrome/browser/sync/test/integration/sessions_helper.cc View 7 chunks +29 lines, -72 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc View 13 chunks +28 lines, -178 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 3 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 4 chunks +15 lines, -24 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc View 9 chunks +65 lines, -61 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/test/fake_server/sessions_hierarchy.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/sync/test/fake_server/sessions_hierarchy.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Sergey Ulanov
Created Revert of [sync] Add Sessions integration tests
3 years, 9 months ago (2017-03-01 00:20:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722953002/1
3 years, 9 months ago (2017-03-01 00:21:39 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 00:36:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aa1ab1dc32ed1b5508c7b835085a...

Powered by Google App Engine
This is Rietveld 408576698