Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2722923002: Move TreeElementMixin to avoid out-of-library private overrides (Closed)

Created:
3 years, 9 months ago by sra1
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, Leaf, vsm, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move TreeElementMixin to avoid out-of-library private overrides This is one of two solutions for Issue 28809 https://codereview.chromium.org/2722923002 https://codereview.chromium.org/2722043002 We should pick one. R=johnniwinther@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/6c76f592a6125d51bda4826f28714145d0fe9f22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -61 lines) Patch
M pkg/compiler/lib/src/resolution/secret_tree_element.dart View 1 chunk +5 lines, -59 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 2 chunks +59 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sra1
3 years, 9 months ago (2017-03-01 00:28:27 UTC) #4
Siggi Cherem (dart-lang)
lgtm - either is fine, I might prefer this one to be honest /cc johnni ...
3 years, 9 months ago (2017-03-09 05:25:07 UTC) #5
Johnni Winther
lgtm
3 years, 9 months ago (2017-03-10 11:10:15 UTC) #7
sra1
3 years, 9 months ago (2017-03-15 16:56:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
6c76f592a6125d51bda4826f28714145d0fe9f22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698