Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2722913002: [chromedriver] Load automation extension using --disable-extensions-except for M57+. (Closed)

Created:
3 years, 9 months ago by samuong
Modified:
3 years, 9 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Load automation extension using --disable-extensions-except for M57+. BUG=chromedriver:1695 TBR=stgao@chromium.org Review-Url: https://codereview.chromium.org/2722913002 Cr-Commit-Position: refs/heads/master@{#453803} Committed: https://chromium.googlesource.com/chromium/src/+/c1da30bf485aad6bb1fda929b830467898495370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722913002/1
3 years, 9 months ago (2017-03-01 00:02:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c1da30bf485aad6bb1fda929b830467898495370
3 years, 9 months ago (2017-03-01 02:57:34 UTC) #5
stgao
lgtm. I assumed that Chrome will ignore unrecognized cmd switches.
3 years, 9 months ago (2017-03-01 18:23:25 UTC) #6
samuong
3 years, 9 months ago (2017-03-01 18:56:51 UTC) #7
Message was sent while issue was closed.
that's correct, it will be ignored in old versions of chrome

Powered by Google App Engine
This is Rietveld 408576698