Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2722783002: Use CallJavascriptFunction instead of CallJavascriptFunctionUnsafe in sign-in error dialog. (Closed)

Created:
3 years, 9 months ago by msarda
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use CallJavascriptFunction instead of CallJavascriptFunctionUnsafe in sign-in error dialog. BUG=NONE Review-Url: https://codereview.chromium.org/2722783002 Cr-Commit-Position: refs/heads/master@{#453886} Committed: https://chromium.googlesource.com/chromium/src/+/a4c85cc905bb9b1bcfa7982968d29f867cb50e46

Patch Set 1 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/webui/signin/signin_error_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
msarda
Please take a look.
3 years, 9 months ago (2017-02-28 12:57:51 UTC) #7
Dan Beam
lgtm
3 years, 9 months ago (2017-03-01 08:36:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722783002/20001
3 years, 9 months ago (2017-03-01 08:51:59 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 08:56:12 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a4c85cc905bb9b1bcfa7982968d2...

Powered by Google App Engine
This is Rietveld 408576698