Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2722733004: customtabs: Benchmark app for WebView / Custom Tabs comparisons. (Closed)

Created:
3 years, 9 months ago by Benoit L
Modified:
3 years, 9 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Benchmark app for WebView / Custom Tabs comparisons. One alternative to Custom Tabs is an in-app browser based on WebView. This commit extends the Custom Tabs test app to allow direct comparisons between WebView and Custom Tabs on devices. The changes are: - New WebViewActivity implementing a very basic WebView-based browser - Added UI to test CCT vs WebView manually BUG=689673 Review-Url: https://codereview.chromium.org/2722733004 Cr-Commit-Position: refs/heads/master@{#455110} Committed: https://chromium.googlesource.com/chromium/src/+/c30689772f29d6ce17a1c2a992ca0f5d6c3eede5

Patch Set 1 #

Patch Set 2 : Please the trybot gods. #

Patch Set 3 : . #

Messages

Total messages: 15 (9 generated)
Benoit L
3 years, 9 months ago (2017-02-28 15:14:07 UTC) #2
Benoit L
On 2017/02/28 15:14:07, Benoit L wrote: ping :-)
3 years, 9 months ago (2017-03-03 08:58:58 UTC) #7
Yusuf
lgtm
3 years, 9 months ago (2017-03-06 17:29:08 UTC) #8
Yusuf
Sorry for the delay!
3 years, 9 months ago (2017-03-06 17:29:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722733004/40001
3 years, 9 months ago (2017-03-07 16:02:44 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 17:20:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c30689772f29d6ce17a1c2a992ca...

Powered by Google App Engine
This is Rietveld 408576698