Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2722733002: Revert of Use TaskScheduler instead of WorkerPool in nss_cert_database.cc. (Closed)

Created:
3 years, 9 months ago by fdoray
Modified:
3 years, 9 months ago
Reviewers:
stevenjb, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, xunjieli
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use TaskScheduler instead of WorkerPool in nss_cert_database.cc. (patchset #4 id:60001 of https://codereview.chromium.org/2603173002/ ) Reason for revert: Using TaskScheduler with NSS is not safe until TaskScheduler supports dynamically growing its thread pool. Original issue's description: > Use TaskScheduler instead of WorkerPool in nss_cert_database.cc. > > Also, remove NSSCertDatabase::SetSlowTaskRunnerForTest(). This method > was used to run slow NSSCertDatabase tasks synchronously in tests. This > is no longer useful since tasks posted through the post_task.h API within > the scope of a ScopedTaskScheduler run synchronously. > > The following traits are used to post tasks to TaskScheduler: > > Priority: Inherited (default) > The priority is inherited from the calling context (i.e. TaskTraits > are initialized with the priority of the current task). > > Shutdown behavior: CONTINUE_ON_SHUTDOWN > Tasks posted with this mode which have not started executing before > shutdown is initiated will never run. Tasks with this mode running at > shutdown will be ignored (the worker will not be joined). > > Note: Tasks that were previously posted to base::WorkerPool should > use this shutdown behavior because this is how base::WorkerPool > handles all its tasks. > > May Block: > Tasks posted with MayBlock() may block. This includes but is not > limited to tasks that wait on synchronous file I/O operations: > read or write a file from disk, interact with a pipe or a socket, > rename or delete a file, enumerate files in a directory, etc. This > trait isn't required for the mere use of locks. > > BUG=659191 > > Review-Url: https://codereview.chromium.org/2603173002 > Cr-Commit-Position: refs/heads/master@{#448059} > Committed: https://chromium.googlesource.com/chromium/src/+/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4 TBR=rsleevi@chromium.org,stevenjb@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=659191 Review-Url: https://codereview.chromium.org/2722733002 Cr-Commit-Position: refs/heads/master@{#453475} Committed: https://chromium.googlesource.com/chromium/src/+/37b8327d48552831f10e5d136f80cdac085abbc7

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -47 lines) Patch
M chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chromeos/cert_loader_unittest.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chromeos/network/auto_connect_handler_unittest.cc View 1 4 chunks +6 lines, -1 line 0 comments Download
M chromeos/network/client_cert_resolver_unittest.cc View 1 3 chunks +4 lines, -1 line 0 comments Download
M chromeos/network/network_cert_migrator_unittest.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/network_connection_handler_unittest.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M net/cert/nss_cert_database.h View 1 4 chunks +13 lines, -0 lines 0 comments Download
M net/cert/nss_cert_database.cc View 1 6 chunks +22 lines, -19 lines 0 comments Download
M net/cert/nss_cert_database_chromeos.cc View 1 2 chunks +4 lines, -8 lines 0 comments Download
M net/cert/nss_cert_database_chromeos_unittest.cc View 1 5 chunks +3 lines, -6 lines 0 comments Download
M net/cert/nss_cert_database_unittest.cc View 1 4 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
fdoray
Created Revert of Use TaskScheduler instead of WorkerPool in nss_cert_database.cc.
3 years, 9 months ago (2017-02-28 01:26:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722733002/1
3 years, 9 months ago (2017-02-28 01:27:09 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/46670) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-02-28 01:31:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722733002/230001
3 years, 9 months ago (2017-02-28 01:36:46 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 02:43:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:230001) as
https://chromium.googlesource.com/chromium/src/+/37b8327d48552831f10e5d136f80...

Powered by Google App Engine
This is Rietveld 408576698