Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2722723003: W3C test importer: Unskip some files with non-utf8 encodings. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

W3C test importer: Unskip some files with non-utf8 encodings. In theory since imports should now be done by Gerrit, this issue may be resolved. BUG=656171 Review-Url: https://codereview.chromium.org/2722723003 Cr-Commit-Position: refs/heads/master@{#454375} Committed: https://chromium.googlesource.com/chromium/src/+/b5b382e1147bcc0f6a6ba5e31ddb0c107564d5a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
qyearsley
3 years, 9 months ago (2017-02-28 16:26:18 UTC) #3
tkent
lgtm
3 years, 9 months ago (2017-03-01 02:21:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722723003/1
3 years, 9 months ago (2017-03-02 20:08:23 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 21:14:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b5b382e1147bcc0f6a6ba5e31ddb...

Powered by Google App Engine
This is Rietveld 408576698