Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_menu_model.mm

Issue 2722693002: [ios] Creates ToolsMenuConstants file (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
diff --git a/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm b/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
index 5387390a167d98725731242a9e5f944fb2b2afbb..a652af3da3b4feb8d6f26607ec900e0d0ed1cb01 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
+++ b/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
@@ -9,6 +9,7 @@
#include "ios/chrome/browser/experimental_flags.h"
#include "ios/chrome/browser/ui/commands/ios_command_ids.h"
#import "ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.h"
+#include "ios/chrome/browser/ui/tools_menu/tools_menu_constants.h"
#include "ios/chrome/browser/ui/ui_util.h"
#include "ios/chrome/grit/ios_strings.h"
#include "ios/public/provider/chrome/browser/chrome_browser_provider.h"
@@ -93,9 +94,9 @@ bool ToolsMenuItemShouldBeVisible(const MenuItemInfo& item,
case IDS_IOS_TOOLS_MENU_SUGGESTIONS:
return experimental_flags::IsSuggestionsUIEnabled();
case IDS_IOS_OPTIONS_REPORT_AN_ISSUE:
- return !ios::GetChromeBrowserProvider()
edchin 2017/02/27 23:02:41 Can you explain this change?
sczs 2017/03/02 22:56:11 This is a bug I introduced when changing the if st
- ->GetUserFeedbackProvider()
- ->IsUserFeedbackEnabled();
+ return ios::GetChromeBrowserProvider()
+ ->GetUserFeedbackProvider()
+ ->IsUserFeedbackEnabled();
default:
return true;
}

Powered by Google App Engine
This is Rietveld 408576698