[ios] Creates ToolsMenuConstants file

ios/chrome/browser/ui/tools_menu/tools_menu_model.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/ui/tools_menu/tools_menu_model.h"
 
 #include "components/reading_list/core/reading_list_switches.h"
 #include "components/strings/grit/components_strings.h"
 #include "ios/chrome/browser/experimental_flags.h"
 #include "ios/chrome/browser/ui/commands/ios_command_ids.h"
 #import "ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.h"
+#include "ios/chrome/browser/ui/tools_menu/tools_menu_constants.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 #include "ios/chrome/grit/ios_strings.h"
 #include "ios/public/provider/chrome/browser/chrome_browser_provider.h"
 #import "ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.h"
 
 // Menu items can be marked as visible or not when Incognito is enabled.
 // The following bits are used for |visibility| field in |MenuItemInfo|.
 const NSInteger kVisibleIncognitoOnly = 1 << 0;
 const NSInteger kVisibleNotIncognitoOnly = 1 << 1;
 
@@ skipping 64 matching lines @@
   switch (item.title_id) {
     case IDS_IOS_TOOLBAR_SHOW_TABS:
       return IsIPadIdiom();
     case IDS_IOS_TOOLS_MENU_READER_MODE:
       return experimental_flags::IsReaderModeEnabled();
     case IDS_IOS_TOOLS_MENU_READING_LIST:
       return reading_list::switches::IsReadingListEnabled();
     case IDS_IOS_TOOLS_MENU_SUGGESTIONS:
       return experimental_flags::IsSuggestionsUIEnabled();
     case IDS_IOS_OPTIONS_REPORT_AN_ISSUE:
-      return !ios::GetChromeBrowserProvider()

[edchin, 2017/02/27 23:02:41]

Can you explain this change?

[sczs, 2017/03/02 22:56:11]

This is a bug I introduced when changing the if statement to this switch. The
downstream test caught it, and this is how it should've been from the start. 

-                  ->GetUserFeedbackProvider()
-                  ->IsUserFeedbackEnabled();
+      return ios::GetChromeBrowserProvider()
+          ->GetUserFeedbackProvider()
+          ->IsUserFeedbackEnabled();
     default:
       return true;
   }
 }