Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3421)

Unified Diff: chrome/browser/ui/webui/welcome_win10_handler.cc

Issue 2722683002: Addressing UX regression on Win10 FRE, and changing timeout behavior (Closed)
Patch Set: adding todo Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/welcome/win10/inline.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/welcome_win10_handler.cc
diff --git a/chrome/browser/ui/webui/welcome_win10_handler.cc b/chrome/browser/ui/webui/welcome_win10_handler.cc
index a72f45c51e2d76dde3b6577288ebf1be337d9c46..e57e746ef64be1453169206397cef5569bd24f2d 100644
--- a/chrome/browser/ui/webui/welcome_win10_handler.cc
+++ b/chrome/browser/ui/webui/welcome_win10_handler.cc
@@ -104,14 +104,14 @@ void WelcomeWin10Handler::HandleGetPinnedToTaskbarState(
}
// Only wait for a small amount of time for the result. If the timer fires,
- // it will be assumed that Chrome is pinned to the taskbar. This is to make
- // sure the instructions are never displayed in case it was impossible to
- // determine the pinned state.
+ // it will be assumed that Chrome isn't pinned to the taskbar. This is to make
+ // sure the instructions are displayed in case it was impossible to determine
+ // the pinned state.
constexpr base::TimeDelta kPinnedToTaskbarTimeout =
base::TimeDelta::FromMilliseconds(200);
timer_.Start(FROM_HERE, kPinnedToTaskbarTimeout,
base::Bind(&WelcomeWin10Handler::OnIsPinnedToTaskbarDetermined,
- base::Unretained(this), true, true));
+ base::Unretained(this), true, false));
}
void WelcomeWin10Handler::HandleSetDefaultBrowser(const base::ListValue* args) {
« no previous file with comments | « chrome/browser/resources/welcome/win10/inline.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698