Addressing UX regression on Win10 FRE, and changing timeout behavior

chrome/browser/ui/webui/welcome_win10_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/welcome_win10_handler.h"
 
 #include "base/bind.h"
 #include "base/metrics/histogram_functions.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/user_metrics.h"
@@ skipping 86 matching lines @@
   bool callback_id_found = args->GetString(0, &pinned_state_callback_id_);
   DCHECK(callback_id_found);
 
   // Send back the result if it is already available.
   if (pinned_state_result_.has_value()) {
     SendPinnedToTaskbarStateResult();
     return;
   }
 
   // Only wait for a small amount of time for the result. If the timer fires,
-  // it will be assumed that Chrome is pinned to the taskbar. This is to make
-  // sure the instructions are never displayed in case it was impossible to
-  // determine the pinned state.
+  // it will be assumed that Chrome isn't pinned to the taskbar. This is to make
+  // sure the instructions are displayed in case it was impossible to determine
+  // the pinned state.
   constexpr base::TimeDelta kPinnedToTaskbarTimeout =
       base::TimeDelta::FromMilliseconds(200);
   timer_.Start(FROM_HERE, kPinnedToTaskbarTimeout,
                base::Bind(&WelcomeWin10Handler::OnIsPinnedToTaskbarDetermined,
-                          base::Unretained(this), true, true));
+                          base::Unretained(this), true, false));
 }
 
 void WelcomeWin10Handler::HandleSetDefaultBrowser(const base::ListValue* args) {
   base::RecordAction(
       base::UserMetricsAction("Win10WelcomePage_SetAsDefaultBrowser"));
   // The worker owns itself.
   (new shell_integration::DefaultBrowserWorker(
        shell_integration::DefaultWebClientWorkerCallback()))
       ->StartSetAsDefault();
 }
@@ skipping 43 matching lines @@
   // sent back.
   if (!pinned_state_callback_id_.empty())
     SendPinnedToTaskbarStateResult();
 }
 
 void WelcomeWin10Handler::SendPinnedToTaskbarStateResult() {
   ResolveJavascriptCallback(
       base::StringValue(pinned_state_callback_id_),
       base::FundamentalValue(pinned_state_result_.value()));
 }