Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1408)

Issue 2722643003: [Bookmark Manager] Add first meaningful paint metric to bookmark manager. (Closed)

Created:
3 years, 9 months ago by calamity
Modified:
3 years, 9 months ago
CC:
chromium-reviews, tfarina, arv+watch_chromium.org, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, tsergeant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Bookmark Manager] Add first meaningful paint metric to bookmark manager. BUG=696823 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2722643003 Cr-Commit-Position: refs/heads/master@{#454139} Committed: https://chromium.googlesource.com/chromium/src/+/4bd4b257955ec0a239783da0d67194be34a77d20

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M chrome/browser/resources/bookmark_manager/js/main.js View 3 chunks +15 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
calamity
+asvitkine for histograms.xml +dbeam for bookmark_manager/ PTAL, thanks!
3 years, 9 months ago (2017-02-28 05:45:17 UTC) #4
Alexei Svitkine (slow)
lgtm
3 years, 9 months ago (2017-02-28 16:31:48 UTC) #6
Dan Beam
lgtm
3 years, 9 months ago (2017-03-01 08:33:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722643003/40001
3 years, 9 months ago (2017-03-02 01:28:50 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 01:40:41 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4bd4b257955ec0a239783da0d671...

Powered by Google App Engine
This is Rietveld 408576698