Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2722623003: Move PwsResultTest to junit (Closed)

Created:
3 years, 9 months ago by cco3
Modified:
3 years, 9 months ago
Reviewers:
nyquist, mattreynolds
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PwsResultTest to junit PwsResultTest does not need to be an instrumentation test, so this change moves it from javatests/ to junit/. BUG=696804 Review-Url: https://codereview.chromium.org/2722623003 Cr-Commit-Position: refs/heads/master@{#454363} Committed: https://chromium.googlesource.com/chromium/src/+/104f81845c1906da368d74c20e4b161a348c0567

Patch Set 1 #

Patch Set 2 : Move PwsResultTest to junit #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -81 lines) Patch
M chrome/android/java_sources.gni View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/PwsResultTest.java View 1 chunk +0 lines, -58 lines 0 comments Download
A + chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/PwsResultTest.java View 1 chunk +24 lines, -23 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
cco3
3 years, 9 months ago (2017-02-28 01:53:00 UTC) #2
mattreynolds
lgtm
3 years, 9 months ago (2017-02-28 02:12:48 UTC) #4
cco3
Hi Tommy, here's another one.
3 years, 9 months ago (2017-02-28 17:12:43 UTC) #6
nyquist
https://codereview.chromium.org/2722623003/diff/20001/chrome/android/java_sources.gni File chrome/android/java_sources.gni (right): https://codereview.chromium.org/2722623003/diff/20001/chrome/android/java_sources.gni#newcode1593 chrome/android/java_sources.gni:1593: "junit/src/org/chromium/chrome/browser/physicalweb/PwsResultTest.java", Shouldn't it also be removed from the other ...
3 years, 9 months ago (2017-02-28 18:27:22 UTC) #7
cco3
https://codereview.chromium.org/2722623003/diff/20001/chrome/android/java_sources.gni File chrome/android/java_sources.gni (right): https://codereview.chromium.org/2722623003/diff/20001/chrome/android/java_sources.gni#newcode1593 chrome/android/java_sources.gni:1593: "junit/src/org/chromium/chrome/browser/physicalweb/PwsResultTest.java", On 2017/02/28 18:27:22, nyquist wrote: > Shouldn't it ...
3 years, 9 months ago (2017-02-28 18:28:39 UTC) #8
nyquist
Ah. It all makes sense now! :-) lgtm
3 years, 9 months ago (2017-02-28 22:43:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722623003/20001
3 years, 9 months ago (2017-02-28 23:00:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/162040) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-02-28 23:04:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722623003/40001
3 years, 9 months ago (2017-03-01 00:34:18 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/399835)
3 years, 9 months ago (2017-03-01 02:20:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722623003/60001
3 years, 9 months ago (2017-03-02 18:45:42 UTC) #21
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 20:30:39 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/104f81845c1906da368d74c20e4b...

Powered by Google App Engine
This is Rietveld 408576698