[css-grid] "normal" alignment is "start" for replaced elements

third_party/WebKit/Source/core/layout/LayoutBox.h

Index: third_party/WebKit/Source/core/layout/LayoutBox.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h
index 8bb840744a271fc962481aca33a32537d20fafdb..d378055571e227c3a8acd529ba593d916df18764 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h
@@ -1381,7 +1381,10 @@ class CORE_EXPORT LayoutBox : public LayoutBoxModelObject {
   void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override;
   void updateFromStyle() override;
 
-  virtual ItemPosition selfAlignmentNormalBehavior() const {
+  virtual ItemPosition selfAlignmentNormalBehavior(
+      const LayoutBox* child = nullptr) const {
+    if (child && child->isLayoutReplaced())

[jfernandez, 2017/03/01 12:46:49]

I think this logic is grid specific, so it should be implemented in Grid, so
other LayoutBox still use stretch as 'normal' behavior.

Also, I don't like too much the new 'child' argument. I've got a proposal; since
this is a grid specific logic, I'd remove this changes in LayoutBox and
implement the different behavior for replaced grid items as part of
LayoutGrid::alignSelfForChild and LayoutGrid::justifySelfForChild 
methods. 

[Manuel Rego, 2017/03/01 17:57:07]

Yeah, good point, it's grid layout specific so I've overridden
this method in LayoutGrid.

The problem is that we still need to have the "child" argument,
as we need to pass the child in LayoutBox::hasStretchedLogicalWidth()
if it's a Grid.

+      return ItemPositionStart;
     return ItemPositionStretch;
   }