[css-grid] "normal" alignment is "start" for replaced elements

third_party/WebKit/Source/core/layout/LayoutBox.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 1363 matching lines @@
 
   void willBeDestroyed() override;
 
   void insertedIntoTree() override;
   void willBeRemovedFromTree() override;
 
   void styleWillChange(StyleDifference, const ComputedStyle& newStyle) override;
   void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override;
   void updateFromStyle() override;
 
-  virtual ItemPosition selfAlignmentNormalBehavior() const {
+  virtual ItemPosition selfAlignmentNormalBehavior(
+      const LayoutBox* child = nullptr) const {
+    if (child && child->isLayoutReplaced())

[jfernandez, 2017/03/01 12:46:49]

I think this logic is grid specific, so it should be implemented in Grid, so
other LayoutBox still use stretch as 'normal' behavior.

Also, I don't like too much the new 'child' argument. I've got a proposal; since
this is a grid specific logic, I'd remove this changes in LayoutBox and
implement the different behavior for replaced grid items as part of
LayoutGrid::alignSelfForChild and LayoutGrid::justifySelfForChild 
methods. 

[Manuel Rego, 2017/03/01 17:57:07]

Yeah, good point, it's grid layout specific so I've overridden
this method in LayoutGrid.

The problem is that we still need to have the "child" argument,
as we need to pass the child in LayoutBox::hasStretchedLogicalWidth()
if it's a Grid.

+      return ItemPositionStart;
     return ItemPositionStretch;
   }
 
   // Returns false if it could not cheaply compute the extent (e.g. fixed
   // background), in which case the returned rect may be incorrect.
   // FIXME: make this a const method once the LayoutBox reference in BoxPainter
   // is const.
   bool getBackgroundPaintedExtent(LayoutRect&) const;
   virtual bool foregroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect,
                                                  unsigned maxDepthToTest) const;
@@ skipping 301 matching lines @@
          breakValue == EBreakBetween::kLeft ||
          breakValue == EBreakBetween::kPage ||
          breakValue == EBreakBetween::kRecto ||
          breakValue == EBreakBetween::kRight ||
          breakValue == EBreakBetween::kVerso;
 }
 
 }  // namespace blink
 
 #endif  // LayoutBox_h