Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2722613003: [css-grid] "normal" alignment is "start" for replaced elements (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 3d8e6aff6c568f4f62405a253c1bb7be86cca4a2..64f75d85006fcf2dbf1c133a888c10ac05f55627 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -2752,11 +2752,11 @@ bool LayoutBox::hasStretchedLogicalWidth() const {
const ComputedStyle* parentStyle = isAnonymous() ? cb->style() : nullptr;
if (cb->isHorizontalWritingMode() != isHorizontalWritingMode())
return style
- .resolvedAlignSelf(cb->selfAlignmentNormalBehavior(),
+ .resolvedAlignSelf(cb->selfAlignmentNormalBehavior(this),
jfernandez 2017/03/01 12:46:49 Try to avoid the new 'child' argument.
Manuel Rego 2017/03/01 17:57:07 We need to pass the child in the case of "cb" is a
parentStyle)
.position() == ItemPositionStretch;
return style
- .resolvedJustifySelf(cb->selfAlignmentNormalBehavior(),
+ .resolvedJustifySelf(cb->selfAlignmentNormalBehavior(this),
parentStyle)
.position() == ItemPositionStretch;
}

Powered by Google App Engine
This is Rietveld 408576698