Chromium Code Reviews Chromium Code Reviews
Issue 2722613003:
[css-grid] "normal" alignment is "start" for replaced elements (Closed)
| Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-stretching-replaced-items.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-stretching-replaced-items.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-stretching-replaced-items.html |
| index f152be82d1f9795ff10bea4ad7e66988886df99b..ef5115f2f8af103939b26771f22b4519421ea154 100644 |
| --- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-stretching-replaced-items.html |
| +++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-stretching-replaced-items.html |
| @@ -1,7 +1,9 @@ |
| <!DOCTYPE html> |
| <link href="resources/grid.css" rel="stylesheet"> |
| <link href="resources/grid-alignment.css" rel="stylesheet"> |
| -<script src="../../resources/check-layout.js"></script> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| +<script src="../../resources/check-layout-th.js"></script> |
| <style> |
| .grid { |
| grid-template-columns: 500px; |
| @@ -17,12 +19,20 @@ |
| </style> |
| <body onload="checkLayout('.grid')"> |
| +<div id="log"></div> |
| <p>This test checks that the alignment properties align-self and justify-self apply the 'stretch' value correctly on replaced elements.</p> |
| <div style="position: relative"> |
| - <p>The blue image's original size is 100px x 100px, but it should be stretched to fill the 500px x 500px grid area it's placed into</p> |
| + <p>The blue image's original size is 100px x 100px, 'normal' is resolved as 'start' for replaced elements so it prevents stretching to be applied.</p> |
| <div class="grid"> |
|
jfernandez
2017/03/01 12:46:49
This case is based on the fact that 'normal' is th
Manuel Rego
2017/03/01 17:57:07
Done.
|
| + <img src="../../images/resources/blue-100.png" data-expected-width="100" data-expected-height="100"/> |
| + </div> |
| +</div> |
| + |
| +<div style="position: relative"> |
| + <p>The blue image's original size is 100px x 100px, but it should be stretched to fill the 500px x 500px grid area it's placed into.</p> |
| + <div class="grid itemsStretch"> |
| <img src="../../images/resources/blue-100.png" data-expected-width="500" data-expected-height="500"/> |
| </div> |
| </div> |
