Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2722603003: s390: Fix logic to check for overflow (Closed)

Created:
3 years, 9 months ago by JaideepBajwa
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: Fix logic to check for overflow R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2722603003 Cr-Commit-Position: refs/heads/master@{#43464} Committed: https://chromium.googlesource.com/v8/v8/+/ef2a9e2debc8b8888348a4231d155e7ddcc86bda

Patch Set 1 #

Patch Set 2 : removed extra file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M src/s390/simulator-s390.cc View 2 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 9 months ago (2017-02-27 22:26:17 UTC) #1
john.yan
lgtm
3 years, 9 months ago (2017-02-27 22:27:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722603003/20001
3 years, 9 months ago (2017-02-27 22:27:57 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 23:16:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/ef2a9e2debc8b8888348a4231d155e7ddcc...

Powered by Google App Engine
This is Rietveld 408576698