Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2722513002: Make PnaclTranslationCacheEntry RefCountedThreadSafe (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
Reviewers:
bradnelson
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make PnaclTranslationCacheEntry RefCountedThreadSafe PnaclTranslationCacheEntry has a non-thread-safe ref count, and usually bound to IO thread. However, disk_cache::BackendIO may be destroyed on CACHE thread, and may drop a reference on it. That causes a data race on the unprotected ref count. BUG=688072 Review-Url: https://codereview.chromium.org/2722513002 Cr-Commit-Position: refs/heads/master@{#453248} Committed: https://chromium.googlesource.com/chromium/src/+/393f08e143d2d7c6d84744221db39516474fb159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/nacl/browser/pnacl_translation_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tzik
PTAL
3 years, 9 months ago (2017-02-27 09:34:44 UTC) #6
bradnelson
lgtm
3 years, 9 months ago (2017-02-27 17:45:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722513002/1
3 years, 9 months ago (2017-02-27 17:46:24 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 17:52:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/393f08e143d2d7c6d84744221db3...

Powered by Google App Engine
This is Rietveld 408576698