Add slice information to DownloadDestinationObserver::DestinationUpdate().

Add slice information to DownloadDestinationObserver::DestinationUpdate().

When destination updates, the slice information should also be sent to the observer.
So that the observer can inform the history db about the changes.

BUG=644352
Review-Url: https://codereview.chromium.org/2722503006
Cr-Commit-Position: refs/heads/master@{#454140}
Committed: https://chromium.googlesource.com/chromium/src/+/c49428ef69cfd173c5d7eaeb39982f44ca68da78

[qinmin, 2017-02-28 20:23:31]

The CQ bit was checked by qinmin@chromium.org to run a CQ dry run

[qinmin, 2017-02-28 20:23:54]

qinmin@chromium.org changed reviewers:
+ asanka@chromium.org, dtrainor@chromium.org, xingliu@chromium.org

[qinmin, 2017-02-28 20:23:55]

PTAL

[commit-bot: I haz the power, 2017-02-28 20:24:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 21:23:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 21:23:20]

Dry run: This issue passed the CQ dry run.

[xingliu, 2017-02-28 22:36:00]

Might need to rebase.

https://codereview.chromium.org/2722503006/diff/1/content/browser/download/do...
File content/browser/download/download_destination_observer.h (right):

https://codereview.chromium.org/2722503006/diff/1/content/browser/download/do...
content/browser/download/download_destination_observer.h:34: const
std::vector<DownloadItem::ReceivedSlice>& received_slices) = 0;
This is called every 0.5 second, is received_slices only used for update the
history db?

[qinmin, 2017-02-28 22:38:21]

https://codereview.chromium.org/2722503006/diff/1/content/browser/download/do...
File content/browser/download/download_destination_observer.h (right):

https://codereview.chromium.org/2722503006/diff/1/content/browser/download/do...
content/browser/download/download_destination_observer.h:34: const
std::vector<DownloadItem::ReceivedSlice>& received_slices) = 0;
On 2017/02/28 22:36:00, xingliu wrote:
> This is called every 0.5 second, is received_slices only used for update the
> history db?

yes, we need to keep the history db up-to-date.

[xingliu, 2017-02-28 22:40:45]

lgtm, I guess if history db can throttle the commit, then we will be fine.

[qinmin, 2017-02-28 22:45:22]

On 2017/02/28 22:40:45, xingliu wrote:
> lgtm, I guess if history db can throttle the commit, then we will be fine.

0.5 sec is not very frequent. And we are already doing this without slice
information(history db is updated whenever byte received changes).

[qinmin, 2017-02-28 22:45:38]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2017-02-28 22:46:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 22:46:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 22:46:20]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[qinmin, 2017-02-28 23:12:34]

The CQ bit was unchecked by qinmin@chromium.org

[qinmin, 2017-03-01 17:32:03]

Patchset #2 (id:20001) has been deleted

[David Trainor- moved to gerrit, 2017-03-01 22:51:23]

lgtm

[qinmin, 2017-03-02 00:18:44]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2017-03-02 00:18:45]

The patchset sent to the CQ was uploaded after l-g-t-m from xingliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2722503006/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-02 00:19:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 01:42:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488413924830610,
"parent_rev": "4bd4b257955ec0a239783da0d67194be34a77d20", "commit_rev":
"c49428ef69cfd173c5d7eaeb39982f44ca68da78"}

[commit-bot: I haz the power, 2017-03-02 01:42:43]

Description was changed from

==========
Add slice information to DownloadDestinationObserver::DestinationUpdate().

When destination updates, the slice information should also be sent to the
observer.
So that the observer can inform the history db about the changes.

BUG=644352
==========

to

==========
Add slice information to DownloadDestinationObserver::DestinationUpdate().

When destination updates, the slice information should also be sent to the
observer.
So that the observer can inform the history db about the changes.

BUG=644352

Review-Url: https://codereview.chromium.org/2722503006
Cr-Commit-Position: refs/heads/master@{#454140}
Committed:
https://chromium.googlesource.com/chromium/src/+/c49428ef69cfd173c5d7eaeb3998...
==========

[commit-bot: I haz the power, 2017-03-02 01:42:44]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c49428ef69cfd173c5d7eaeb3998...