Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2722503004: Route through the BGTaskScheduler when receiving a message for the GCM Driver (Closed)

Created:
3 years, 9 months ago by Peter Beverloo
Modified:
3 years, 9 months ago
Reviewers:
nyquist, awdf, M-A Ruel
CC:
chromium-reviews, awdf+watch_chromium.org, zea+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, agrieve+watch_chromium.org, harkness+watch_chromium.org, johnme+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Route through the BGTaskScheduler when receiving a message for the GCM Driver There are cases when the message handling routine for a received GCM message may be limited to ten seconds of execution time. Route messages through the backgroudn task scheduler since we may need more than that, which is the case for some of the GCM Driver's customers (e.g. Web Push Notifications.) BUG=688898 Review-Url: https://codereview.chromium.org/2722503004 Cr-Commit-Position: refs/heads/master@{#453441} Committed: https://chromium.googlesource.com/chromium/src/+/943bc63a8ff268394bdc0092c77977001626066c

Patch Set 1 #

Patch Set 2 : Route through the BGTaskScheduler when receiving a message for the GCM Driver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+523 lines, -63 lines) Patch
M chrome/android/java/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationJobService.java View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/services/gcm/ChromeGcmListenerService.java View 5 chunks +69 lines, -24 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/services/gcm/GCMBackgroundTask.java View 1 chunk +58 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java View 2 chunks +6 lines, -1 line 0 comments Download
M components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/TaskIds.java View 1 chunk +3 lines, -0 lines 0 comments Download
M components/gcm_driver/android/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java View 3 chunks +5 lines, -33 lines 0 comments Download
A components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMMessage.java View 1 chunk +177 lines, -0 lines 0 comments Download
A components/gcm_driver/android/junit/src/org/chromium/components/gcm_driver/GCMMessageTest.java View 1 chunk +178 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/buildbot/manage.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
M-A Ruel
lgtm
3 years, 9 months ago (2017-02-27 23:18:08 UTC) #2
Peter Beverloo
+awdf and nyquist again
3 years, 9 months ago (2017-02-27 23:27:26 UTC) #6
nyquist
lgtm
3 years, 9 months ago (2017-02-27 23:29:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722503004/1
3 years, 9 months ago (2017-02-27 23:31:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722503004/20001
3 years, 9 months ago (2017-02-28 00:19:13 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 01:41:25 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/943bc63a8ff268394bdc0092c779...

Powered by Google App Engine
This is Rietveld 408576698