[CSS Typed OM] Specify and check separators for repeated properties

third_party/WebKit/Source/build/scripts/make_css_property_metadata.py

Index: third_party/WebKit/Source/build/scripts/make_css_property_metadata.py
diff --git a/third_party/WebKit/Source/build/scripts/make_css_property_metadata.py b/third_party/WebKit/Source/build/scripts/make_css_property_metadata.py
index b7ebe71c78f03eb30e4f1373c49a406af27ae46a..c4dc7427cdee7fd015c0ca3d0d03ac4d6938f211 100755
--- a/third_party/WebKit/Source/build/scripts/make_css_property_metadata.py
+++ b/third_party/WebKit/Source/build/scripts/make_css_property_metadata.py
@@ -28,7 +28,7 @@ class CSSPropertyMetadataWriter(css_properties.CSSProperties):
                          ('interpolable', 'isInterpolableProperty'),
                          ('inherited', 'isInheritedProperty'),
                          ('supports_percentage', 'propertySupportsPercentage'),
-                         ('repeated', 'propertyIsRepeated')
+                         ('separator', 'propertyIsRepeated')

[sashab, 2017/02/28 23:20:47]

Not sure about this part. Do we need propertyIsRepeated anymore? Seems confusing
that the other generated methods from this have similar names to their key.

I'd either rename this to propertyHasSeparator, or just delete it altogether and
update callsites to use repetitionSeparator().

Alternatively, you could update the generator to support returning 'char' as
well as 'bool', and this method could be fully generated :)

[meade_UTC10, 2017/03/01 06:20:28]

It's really nice to have both - there are lots of places that only check whether
the property is repeated, and it would be annoying to have to check the value
separator explicitly each time. However, I can add a non-generated function that
just calls the repetitionSeparator() function instead.

                         ],
             'first_enum_value': self._first_enum_value,
         }