[CSS Typed OM] Specify and check separators for repeated properties

third_party/WebKit/Source/build/scripts/make_css_property_metadata.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import sys
 
 import css_properties
 import json5_generator
 from name_utilities import lower_first
@@ skipping 10 matching lines @@
         self._outputs = {'CSSPropertyMetadata.cpp': self.generate_css_property_metadata_cpp}
 
     @template_expander.use_jinja('CSSPropertyMetadata.cpp.tmpl', filters=filters)
     def generate_css_property_metadata_cpp(self):
         return {
             'properties': self._properties,
             'switches': [('descriptor_only', 'isDescriptorOnly'),
                          ('interpolable', 'isInterpolableProperty'),
                          ('inherited', 'isInheritedProperty'),
                          ('supports_percentage', 'propertySupportsPercentage'),
-                         ('repeated', 'propertyIsRepeated')
+                         ('separator', 'propertyIsRepeated')

[sashab, 2017/02/28 23:20:47]

Not sure about this part. Do we need propertyIsRepeated anymore? Seems confusing
that the other generated methods from this have similar names to their key.

I'd either rename this to propertyHasSeparator, or just delete it altogether and
update callsites to use repetitionSeparator().

Alternatively, you could update the generator to support returning 'char' as
well as 'bool', and this method could be fully generated :)

[meade_UTC10, 2017/03/01 06:20:28]

It's really nice to have both - there are lots of places that only check whether
the property is repeated, and it would be annoying to have to check the value
separator explicitly each time. However, I can add a non-generated function that
just calls the repetitionSeparator() function instead.

                         ],
             'first_enum_value': self._first_enum_value,
         }
 
 
 if __name__ == '__main__':
     json5_generator.Maker(CSSPropertyMetadataWriter).main()