Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2722483004:
Replace net-internals/export tab with deprecation msg and button to show old UI. (Closed)
DescriptionReplace net-internals/export tab with deprecation msg and button to show old UI.
BUG=472699, 678386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2722483004
Cr-Commit-Position: refs/heads/master@{#453830}
Committed: https://chromium.googlesource.com/chromium/src/+/2af8682325e9d307418b66df111c639f9bb1792d
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fixed Eric's comment from ps1 #Patch Set 3 : Rebase #
Messages
Total messages: 25 (14 generated)
Description was changed from ========== Replace net-internals/export tab with deprecation msg and button to show old UI. BUG=472699 ========== to ========== Replace net-internals/export tab with deprecation msg and button to show old UI. BUG=472699 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Replace net-internals/export tab with deprecation msg and button to show old UI. BUG=472699 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Replace net-internals/export tab with deprecation msg and button to show old UI. BUG=472699,678386 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
wangyix@chromium.org changed reviewers: + eroman@chromium.org, wangyix@chromium.org
PTAL
This CL makes net-internals/export looks like this: https://drive.google.com/a/google.com/file/d/0B0K4h5WHKlzlUGZzYkNjbV93SEU/vie...
https://codereview.chromium.org/2722483004/diff/1/chrome/browser/resources/ne... File chrome/browser/resources/net_internals/export_view.html (right): https://codereview.chromium.org/2722483004/diff/1/chrome/browser/resources/ne... chrome/browser/resources/net_internals/export_view.html:22: <b>NOTICE</b>: chrome://net-internals is being deprecated. How about simplifying the text to just talk about net-export: ----------------------------- WARNING: chrome://net-net internals is being deprecated for exporting log files (crbug.com/678386) Use chrome://net-export instead. <button>Show the deprecated UI</button> ----------------------------- My main points are: (1) Include the bug number, so people have somewhere to complain / find more information (2) Let's not confuse things with net-internals viewing deprecation yet (don't want to indicate it as such until the replacement has tests and is updated)
https://codereview.chromium.org/2722483004/diff/1/chrome/browser/resources/ne... File chrome/browser/resources/net_internals/export_view.html (right): https://codereview.chromium.org/2722483004/diff/1/chrome/browser/resources/ne... chrome/browser/resources/net_internals/export_view.html:22: <b>NOTICE</b>: chrome://net-internals is being deprecated. On 2017/02/28 00:24:40, eroman wrote: > How about simplifying the text to just talk about net-export: > ----------------------------- > WARNING: chrome://net-net internals is being deprecated for exporting log files > (crbug.com/678386) > > Use chrome://net-export instead. > > <button>Show the deprecated UI</button> > ----------------------------- > > My main points are: > (1) Include the bug number, so people have somewhere to complain / find more > information > (2) Let's not confuse things with net-internals viewing deprecation yet (don't > want to indicate it as such until the replacement has tests and is updated) Done.
lgtm
The CQ bit was checked by wangyix@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by wangyix@chromium.org
The CQ bit was unchecked by wangyix@chromium.org
The CQ bit was unchecked by wangyix@chromium.org
The CQ bit was checked by wangyix@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org Link to the patchset: https://codereview.chromium.org/2722483004/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by wangyix@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488335462542570,
"parent_rev": "97478718186873ae5a7e2215d4078c23c9fef4f5", "commit_rev":
"2af8682325e9d307418b66df111c639f9bb1792d"}
Message was sent while issue was closed.
Description was changed from ========== Replace net-internals/export tab with deprecation msg and button to show old UI. BUG=472699,678386 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Replace net-internals/export tab with deprecation msg and button to show old UI. BUG=472699,678386 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2722483004 Cr-Commit-Position: refs/heads/master@{#453830} Committed: https://chromium.googlesource.com/chromium/src/+/2af8682325e9d307418b66df111c... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/2af8682325e9d307418b66df111c... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
