[turbofan] Introduce dedicated ObjectIsNaN operator.

[turbofan] Introduce dedicated ObjectIsNaN operator.

We can compile a !== a and Number.isNaN(a) to ObjectIsNaN. The former is
commonly used to check for NaN, i.e. in case of equals in AngularJS.

R=jarin@chromium.org
BUG=v8:5267
Review-Url: https://codereview.chromium.org/2722483003
Cr-Commit-Position: refs/heads/master@{#43572}
Committed: https://chromium.googlesource.com/v8/v8/+/de52562d8e6fec7949cafd39bb7aa58d3269ac8e

[Benedikt Meurer, 2017-02-27 14:04:34]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 14:04:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 14:27:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 14:27:35]

Dry run: This issue passed the CQ dry run.

[Jarin, 2017-02-27 15:15:49]

https://codereview.chromium.org/2722483003/diff/1/src/compiler/simplified-low...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/2722483003/diff/1/src/compiler/simplified-low...
src/compiler/simplified-lowering.cc:2551: VisitUnop(node, UseInfo::None(),
MachineRepresentation::kBit);
Are you sure it is ok to change the use infos based on the type, here?

If you really want to keep it this way, please write mjsunit tests that test the
paths through here, especially all the possible changes from one path to
another.

[Benedikt Meurer, 2017-03-03 08:41:50]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 08:41:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-03-03 08:42:15]

Feedback addressed.

https://codereview.chromium.org/2722483003/diff/1/src/compiler/simplified-low...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/2722483003/diff/1/src/compiler/simplified-low...
src/compiler/simplified-lowering.cc:2551: VisitUnop(node, UseInfo::None(),
MachineRepresentation::kBit);
Changed to GetUpperBound now, and added tests.

[Jarin, 2017-03-03 08:59:58]

lgtm

lgtm, thanks!

[Benedikt Meurer, 2017-03-03 09:01:16]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-03-03 09:01:20]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-03-03 09:01:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 09:08:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488531680410190,
"parent_rev": "7631b923ca6887155550dede4d339085fcf997e5", "commit_rev":
"de52562d8e6fec7949cafd39bb7aa58d3269ac8e"}

[commit-bot: I haz the power, 2017-03-03 09:08:19]

Description was changed from

==========
[turbofan] Introduce dedicated ObjectIsNaN operator.

We can compile a !== a and Number.isNaN(a) to ObjectIsNaN. The former is
commonly used to check for NaN, i.e. in case of equals in AngularJS.

R=jarin@chromium.org
BUG=v8:5267
==========

to

==========
[turbofan] Introduce dedicated ObjectIsNaN operator.

We can compile a !== a and Number.isNaN(a) to ObjectIsNaN. The former is
commonly used to check for NaN, i.e. in case of equals in AngularJS.

R=jarin@chromium.org
BUG=v8:5267

Review-Url: https://codereview.chromium.org/2722483003
Cr-Commit-Position: refs/heads/master@{#43572}
Committed:
https://chromium.googlesource.com/v8/v8/+/de52562d8e6fec7949cafd39bb7aa58d326...
==========

[commit-bot: I haz the power, 2017-03-03 09:08:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/de52562d8e6fec7949cafd39bb7aa58d326...