Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2722463003: Gtk: Fix GCC 6.1.0 build (Closed)

Created:
3 years, 9 months ago by Tom (Use chromium acct)
Modified:
3 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk: Fix GCC 6.1.0 build This CL removes PickButtonTintFromColors from gtk_ui.cc. This function was not used, and apparently only Gcc 6 caught this. BUG=694497 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2722463003 Cr-Commit-Position: refs/heads/master@{#453286} Committed: https://chromium.googlesource.com/chromium/src/+/4710b6a7757ede0b8dd6850a09f96d876ab48236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -61 lines) Patch
M chrome/browser/ui/libgtkui/gtk_ui.cc View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom (Use chromium acct)
3 years, 9 months ago (2017-02-27 18:15:22 UTC) #1
Elliot Glaysher
lgtm BTW, This was the sort of code I was talking about when I was ...
3 years, 9 months ago (2017-02-27 18:20:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722463003/1
3 years, 9 months ago (2017-02-27 19:09:09 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 19:15:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4710b6a7757ede0b8dd6850a09f9...

Powered by Google App Engine
This is Rietveld 408576698