Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2722453003: MD Settings: Eliminate potential 2nd scrollbar when dialog is shown. (Closed)

Created:
3 years, 9 months ago by dpapad
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Eliminate potential 2nd scrollbar when dialog is shown. BUG=694856 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2722453003 Cr-Commit-Position: refs/heads/master@{#453993} Committed: https://chromium.googlesource.com/chromium/src/+/54620e7a10bd00609a7c428a3f734ac121abcacb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings.html View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dpapad
Before/after: http://imgur.com/a/jQfLE @dbeam: I think is OK to not be able to scroll left/right to ...
3 years, 9 months ago (2017-02-27 23:57:19 UTC) #3
dpapad
On 2017/02/27 at 23:57:19, dpapad wrote: > Before/after: http://imgur.com/a/jQfLE > > @dbeam: I think is ...
3 years, 9 months ago (2017-03-01 00:37:18 UTC) #4
Dan Beam
ehhhhhhh, OK lgtm
3 years, 9 months ago (2017-03-01 08:34:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722453003/1
3 years, 9 months ago (2017-03-01 18:23:39 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 19:18:46 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/54620e7a10bd00609a7c428a3f73...

Powered by Google App Engine
This is Rietveld 408576698