[NaCl SDK] Various fixes so "make debug" works on Windows.

[NaCl SDK] Various fixes so "make debug" works on Windows.

* CHROME_PATH_ESCAPE was wrong (Windows doesn't need space escaping)
* run.py wasn't running a debugger
* Chrome wasn't being run with --no-sandbox when debugging 
  Windows. Turns out that is the only case where it is needed.

BUG=364223
R=sbc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270009

[Sam Clegg, 2014-05-09 23:29:03]

lgtm.

I thought we didn't need --no-sandbox these days?

[binji, 2014-05-09 23:45:20]

On 2014/05/09 23:29:03, Sam Clegg wrote:
> lgtm.
> 
> I thought we didn't need --no-sandbox these days?

Me too, but I got an error when running without it. It's only necessary for the
debug stub on Windows, AFAICT. Let me test that theory. If so, I'll remove it
for the other platforms.

[binji, 2014-05-09 23:48:21]

On 2014/05/09 23:45:20, binji wrote:
> On 2014/05/09 23:29:03, Sam Clegg wrote:
> > lgtm.
> > 
> > I thought we didn't need --no-sandbox these days?
> 
> Me too, but I got an error when running without it. It's only necessary for
the
> debug stub on Windows, AFAICT. Let me test that theory. If so, I'll remove it
> for the other platforms.

Oh, wait. It wasn't enabled before for "make debug", so of course it works on
Mac, Linux without it... I'll remove it from "make run" as well.

[binji, 2014-05-09 23:53:30]

On 2014/05/09 23:48:21, binji wrote:
> On 2014/05/09 23:45:20, binji wrote:
> > On 2014/05/09 23:29:03, Sam Clegg wrote:
> > > lgtm.
> > > 
> > > I thought we didn't need --no-sandbox these days?
> > 
> > Me too, but I got an error when running without it. It's only necessary for
> the
> > debug stub on Windows, AFAICT. Let me test that theory. If so, I'll remove
it
> > for the other platforms.
> 
> Oh, wait. It wasn't enabled before for "make debug", so of course it works on
> Mac, Linux without it... I'll remove it from "make run" as well.

Ah, I see. You re-added --no-sandbox to run Linux host builds in r236358.

[binji, 2014-05-12 19:37:30]

The CQ bit was checked by binji@chromium.org

[commit-bot: I haz the power, 2014-05-12 19:37:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/binji@chromium.org/272243006/40001

[commit-bot: I haz the power, 2014-05-12 23:21:04]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-13 04:11:02]

Change committed as 270009