native_client_sdk/src/tools/run.py - Issue 272243006: [NaCl SDK] Various fixes so "make debug" works on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tools/run.py

Issue 272243006: [NaCl SDK] Various fixes so "make debug" works on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge master Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/tools/run.py

diff --git a/native_client_sdk/src/tools/run.py b/native_client_sdk/src/tools/run.py

index fb99b6d34a554656033a152b727e5f11c9aa39d0..52f059038fb0d8886565321e5c61a8137188841b 100755

--- a/native_client_sdk/src/tools/run.py

+++ b/native_client_sdk/src/tools/run.py

@@ -74,8 +74,9 @@ def main(args):

cmd = ['osascript', '-e',

'tell application "Terminal" to do script "%s"' %

' '.join(r'\"%s\"' % x for x in options.debug)]

- else:

- cmd = []

+ elif getos.GetPlatform() == 'win':

+ cmd = ['cmd.exe', '/c', 'start', 'cmd.exe', '/c']

+ cmd += options.debug

print 'Starting debugger: ' + ' '.join(cmd)

debug_process = subprocess.Popen(cmd, env=env)

else:

« no previous file with comments | « native_client_sdk/src/tools/common.mk ('k') | no next file » | no next file with comments »