Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 272243002: Revert "Reland r20974: Unify and simplify the FastCloneShallowArrayStub" (Closed)

Created:
6 years, 7 months ago by Toon Verwaest
Modified:
6 years, 7 months ago
Reviewers:
Igor Sheludko, danno
CC:
v8-dev
Visibility:
Public.

Description

Revert "Reland r20974: Unify and simplify the FastCloneShallowArrayStub" This breaks nosnap. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -386 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +23 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +25 lines, -2 lines 0 comments Download
M src/code-stubs.h View 3 chunks +46 lines, -10 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 5 chunks +45 lines, -47 lines 0 comments Download
M src/compiler.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/counters.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.h View 3 chunks +8 lines, -29 lines 0 comments Download
M src/hydrogen.cc View 6 chunks +111 lines, -213 lines 0 comments Download
M src/hydrogen-gvn.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +33 lines, -2 lines 0 comments Download
M src/lithium.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +12 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +32 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 7 months ago (2014-05-09 17:55:43 UTC) #1
Igor Sheludko
lgtm
6 years, 7 months ago (2014-05-09 17:55:59 UTC) #2
Toon Verwaest
6 years, 7 months ago (2014-05-09 17:57:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21242 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698