src/hydrogen-gvn.cc - Issue 272243002: Revert "Reland r20974: Unify and simplify the FastCloneShallowArrayStub"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-gvn.cc

Issue 272243002: Revert "Reland r20974: Unify and simplify the FastCloneShallowArrayStub" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen-gvn.cc

diff --git a/src/hydrogen-gvn.cc b/src/hydrogen-gvn.cc

index b32b90951a95f991cadcfe2b4ee7f5a94064337e..f9d1b408a7f7840b0a618340f2488845b3b1ba49 100644

--- a/src/hydrogen-gvn.cc

+++ b/src/hydrogen-gvn.cc

@@ -863,8 +863,7 @@ void HGlobalValueNumberingPhase::AnalyzeGraph() {

stream.OutputToStdOut();

}

- if (instr->CheckFlag(HValue::kUseGVN) &&

- !instr->CheckFlag(HValue::kCantBeReplaced)) {

+ if (instr->CheckFlag(HValue::kUseGVN)) {

ASSERT(!instr->HasObservableSideEffects());

HInstruction* other = map->Lookup(instr);

if (other != NULL) {

« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »