Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1328)

Issue 2722413005: Migrate WTF::LinkedHashSet/ListHashSet::first() to ::front() (Closed)

Created:
3 years, 9 months ago by pilgrim_google
Modified:
3 years, 9 months ago
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-wtf_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, eae+blinkwatch, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, Mikhail, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::LinkedHashSet/ListHashSet::first() to ::front() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2722413005 Cr-Commit-Position: refs/heads/master@{#454631} Committed: https://chromium.googlesource.com/chromium/src/+/c1e9bdb6d21349e58a1c1bc6444d776967768011

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/LinkedHashSet.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSet.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSetTest.cpp View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
pilgrim_google
3 years, 9 months ago (2017-03-03 15:35:03 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-03 18:16:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722413005/1
3 years, 9 months ago (2017-03-03 18:32:50 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 18:37:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c1e9bdb6d21349e58a1c1bc6444d...

Powered by Google App Engine
This is Rietveld 408576698