Revert of [TSAN] Fix data race with base::i18n text direction.

Revert of [TSAN] Fix data race with base::i18n text direction. (patchset #1 id:1 of https://codereview.chromium.org/2716003002/ )

Reason for revert:
IsRTL is called a lot and this caused serious performance impact.

Original issue's description:
> [TSAN] Fix data race with base::i18n text direction.
> 
> The global g_icu_text_direction could be read/written from
> any thread that called base::i18n::IsRTL resulting in a data race.
> Guard read/writes with a mutex.
> 
> BUG=695929
> TEST=base_unittests
> 
> Review-Url: https://codereview.chromium.org/2716003002
> Cr-Commit-Position: refs/heads/master@{#454108}
> Committed: https://chromium.googlesource.com/chromium/src/+/d27e590ad6471e444e164597ee22a80c7801451d

TBR=jshin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=695929
Review-Url: https://codereview.chromium.org/2722413004
Cr-Commit-Position: refs/heads/master@{#455392}
Committed: https://chromium.googlesource.com/chromium/src/+/8c019d90a9527169ba4ed43f0cc80b40c49dbc28

[mbjorge, 2017-03-02 17:35:52]

The CQ bit was checked by mbjorge@chromium.org

[mbjorge, 2017-03-02 17:35:52]

Created Revert of [TSAN] Fix data race with base::i18n text direction.

[commit-bot: I haz the power, 2017-03-02 17:36:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 17:36:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 17:36:11]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[mbjorge, 2017-03-02 17:36:53]

mbjorge@chromium.org changed reviewers:
+ ronefrati@gmail.com

[mbjorge, 2017-03-07 21:34:53]

ping

[jungshik at Google, 2017-03-08 06:52:19]

On 2017/03/07 21:34:53, mbjorge wrote:
> ping

Sorry. I thought about a perf issue in the initial CL, but didn't expect isRTL
to be called in so many places. 

LGTM for now. We have to think about a better way.

[jungshik at Google, 2017-03-08 06:52:24]

The CQ bit was checked by jshin@chromium.org

[jungshik at Google, 2017-03-08 06:52:30]

The CQ bit was checked by jshin@chromium.org

[commit-bot: I haz the power, 2017-03-08 06:52:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 06:53:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488955950075900, "parent_rev":
"05810da6bb500c8421bdd840522142b50f3265c8", "commit_rev":
"8c019d90a9527169ba4ed43f0cc80b40c49dbc28"}

[commit-bot: I haz the power, 2017-03-08 06:54:18]

Description was changed from

==========
Revert of [TSAN] Fix data race with base::i18n text direction. (patchset #1 id:1
of https://codereview.chromium.org/2716003002/ )

Reason for revert:
IsRTL is called a lot and this caused serious performance impact.

Original issue's description:
> [TSAN] Fix data race with base::i18n text direction.
> 
> The global g_icu_text_direction could be read/written from
> any thread that called base::i18n::IsRTL resulting in a data race.
> Guard read/writes with a mutex.
> 
> BUG=695929
> TEST=base_unittests
> 
> Review-Url: https://codereview.chromium.org/2716003002
> Cr-Commit-Position: refs/heads/master@{#454108}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d27e590ad6471e444e164597ee22...

TBR=jshin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=695929
==========

to

==========
Revert of [TSAN] Fix data race with base::i18n text direction. (patchset #1 id:1
of https://codereview.chromium.org/2716003002/ )

Reason for revert:
IsRTL is called a lot and this caused serious performance impact.

Original issue's description:
> [TSAN] Fix data race with base::i18n text direction.
> 
> The global g_icu_text_direction could be read/written from
> any thread that called base::i18n::IsRTL resulting in a data race.
> Guard read/writes with a mutex.
> 
> BUG=695929
> TEST=base_unittests
> 
> Review-Url: https://codereview.chromium.org/2716003002
> Cr-Commit-Position: refs/heads/master@{#454108}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d27e590ad6471e444e164597ee22...

TBR=jshin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=695929

Review-Url: https://codereview.chromium.org/2722413004
Cr-Commit-Position: refs/heads/master@{#455392}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c019d90a9527169ba4ed43f0cc8...
==========

[commit-bot: I haz the power, 2017-03-08 06:54:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c019d90a9527169ba4ed43f0cc8...

[dcheng, 2017-03-08 07:29:36]

On 2017/03/08 06:54:19, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/8c019d90a9527169ba4ed43f0cc8...

[dcheng, 2017-03-08 07:29:37]

On 2017/03/08 06:54:19, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/8c019d90a9527169ba4ed43f0cc8...

[dcheng, 2017-03-08 07:30:39]

On 2017/03/08 07:29:37, dcheng wrote:
> On 2017/03/08 06:54:19, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/8c019d90a9527169ba4ed43f0cc8...

Umm, don't know why Rietveld did that, sorry for the spam.

I wasn't going to comment originally, but since I'm already spamming this
review, would it be possible to include context links in the revert message to
the perf bug where this came up in the future? Thanks.