Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2722343002: DOM: Fix a getElementsByTagName regression by r454059. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DOM: Fix a getElementsByTagName regression by r454059. r454059 introduced an inconsistency of Document::convertLocalName() and HTMLTagCollection constructor, and it caused unexpected behavior for non-ASCII element names. These two functions should use the same lowercase function. BUG=697658 R=yosin@chromium.org Review-Url: https://codereview.chromium.org/2722343002 . Cr-Commit-Position: refs/heads/master@{#454145} Committed: https://chromium.googlesource.com/chromium/src/+/2f5e0aa4f9ab6fe3eb226bdfcb86e305f652e6bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-getElementsByTagName-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Element-getElementsByTagName-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/case-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTagCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
tkent
yosin@, would you review this please?
3 years, 9 months ago (2017-03-02 01:10:49 UTC) #7
yosin_UTC9
lgtm
3 years, 9 months ago (2017-03-02 01:32:40 UTC) #8
tkent
3 years, 9 months ago (2017-03-02 01:50:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2f5e0aa4f9ab6fe3eb226bdfcb86e305f652e6bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698