Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2722323002: Free mdm library after use. (Closed)

Created:
3 years, 9 months ago by Roger Tawa OOO till Jul 10th
Modified:
3 years, 9 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Free mdm library after use. BUG=690163 Review-Url: https://codereview.chromium.org/2722323002 Cr-Commit-Position: refs/heads/master@{#454593} Committed: https://chromium.googlesource.com/chromium/src/+/08f4cddf58834a8d8a7d7057e0b8d020c8ef73e1

Patch Set 1 #

Patch Set 2 : Remove namespace #

Total comments: 2

Patch Set 3 : Make windows specific #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M base/win/win_util.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Roger Tawa OOO till Jul 10th
Hi Greg, Please take a look. Thanks.
3 years, 9 months ago (2017-03-01 21:55:29 UTC) #6
grt (UTC plus 2)
lgtm with a nit https://codereview.chromium.org/2722323002/diff/20001/base/win/win_util.cc File base/win/win_util.cc (right): https://codereview.chromium.org/2722323002/diff/20001/base/win/win_util.cc#newcode505 base/win/win_util.cc:505: FilePath::FromUTF8Unsafe(GetNativeLibraryName("MDMRegistration"))); since this isn't cross-platform ...
3 years, 9 months ago (2017-03-03 09:31:35 UTC) #9
Roger Tawa OOO till Jul 10th
Thanks Greg. https://codereview.chromium.org/2722323002/diff/20001/base/win/win_util.cc File base/win/win_util.cc (right): https://codereview.chromium.org/2722323002/diff/20001/base/win/win_util.cc#newcode505 base/win/win_util.cc:505: FilePath::FromUTF8Unsafe(GetNativeLibraryName("MDMRegistration"))); On 2017/03/03 09:31:35, grt (UTC plus ...
3 years, 9 months ago (2017-03-03 15:18:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722323002/40001
3 years, 9 months ago (2017-03-03 15:19:16 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 16:20:46 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/08f4cddf58834a8d8a7d7057e0b8...

Powered by Google App Engine
This is Rietveld 408576698