Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Issue 2722263002: Add function document, and small refactor around Start/StopArc(). (Closed)

Created:
3 years, 9 months ago by hidehiko
Modified:
3 years, 9 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, oshima+watch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add function document, and small refactor around Start/StopArc(). This CL has several minor refactoring. - Add function comments to StartArc(), StopArc() and OnProvisioningFinished(). - Moved StartArc() and StopArc() into private. - Introduced StartArcForTesting() proxy only for testing purpose. - Reorder StartArc() and StopArc() in .cc file. BUG=n/a TEST=Ran bots. Review-Url: https://codereview.chromium.org/2722263002 Cr-Commit-Position: refs/heads/master@{#454166} Committed: https://chromium.googlesource.com/chromium/src/+/0e38d14cf1c750b1c7984b2d0b30c12b4f8470ff

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -35 lines) Patch
M chrome/browser/chromeos/arc/arc_session_manager.h View 1 4 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_session_manager.cc View 1 3 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_session_manager_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
hidehiko
Yusuke-san, let me address your comments for https://codereview.chromium.org/2723073002/, here. PTAL.
3 years, 9 months ago (2017-03-01 19:13:51 UTC) #4
Yusuke Sato
lgtm, thanks!
3 years, 9 months ago (2017-03-01 19:46:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722263002/1
3 years, 9 months ago (2017-03-02 01:46:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/376331)
3 years, 9 months ago (2017-03-02 02:00:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722263002/20001
3 years, 9 months ago (2017-03-02 02:27:44 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 03:40:41 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e38d14cf1c750b1c7984b2d0b30...

Powered by Google App Engine
This is Rietveld 408576698