Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2722213002: [ValueSerializer] Allow wire format versions beginning with 13 to be deserialized in non-legacy mod… (Closed)

Created:
3 years, 9 months ago by jbroman
Modified:
3 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ValueSerializer] Allow wire format versions beginning with 13 to be deserialized in non-legacy mode. As of version 13, delegates do not need to worry about colliding tags with the tags reserved by v8, since v8 inserts a "host object" prefix beforehand. Thus the format is now suitable for more general use, without opting into the "legacy" mode that had this caveat. Review-Url: https://codereview.chromium.org/2722213002 Cr-Commit-Position: refs/heads/master@{#43521} Committed: https://chromium.googlesource.com/v8/v8/+/a927f81c7c16e6c3d53e590404c954e523b115db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/api.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jbroman
Now that the format has slightly fewer pitfalls, I'm hoping to allow this API to ...
3 years, 9 months ago (2017-03-01 15:48:22 UTC) #4
Jakob Kummerow
lgtm
3 years, 9 months ago (2017-03-01 16:23:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722213002/1
3 years, 9 months ago (2017-03-01 16:32:45 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 16:34:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a927f81c7c16e6c3d53e590404c954e523b...

Powered by Google App Engine
This is Rietveld 408576698