Update MenuControllerTest Widget Creation

Update MenuControllerTest Widget Creation

Two menu tests actively tested the handling of drag and drop within aura's
nested message loop. To do this they set a testing DragDropClient on the root
window by AuraTestHelper.

While this is fine with the classic window server, when being ran as a part of
the views_mus_unittests the WindowTreeClient properly constructs root windows
as needed. This lead to the test having two competiting window trees, and the
test client being installed on the incorrect one.

I've updated the tests to create the full menu/submenu tree, and to install the
DragDropClient on the correct window tree.

TEST=MenuControllerTest.MenuControllerReplacedDuringDrag,
MenuControllerTest.CancelAllDuringDrag
BUG=664280
Review-Url: https://codereview.chromium.org/2722193003
Cr-Commit-Position: refs/heads/master@{#454259}
Committed: https://chromium.googlesource.com/chromium/src/+/e0f5db25384b1c70388a90c8c77d33962d19d524

[jonross, 2017-03-01 23:26:27]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-03-01 23:26:28]

Hey sky@ could you review this change to two tests which were broken in
views_mus_unittests.

Thanks,
Jon

[sky, 2017-03-02 03:14:05]

LGTM

[jonross, 2017-03-02 14:47:39]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-03-02 14:47:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 15:07:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488466059432710, "parent_rev":
"0a06fdaf8ba732ae795bcb1f2331523babc88dd8", "commit_rev":
"e0f5db25384b1c70388a90c8c77d33962d19d524"}

[commit-bot: I haz the power, 2017-03-02 15:08:24]

Description was changed from

==========
Update MenuControllerTest Widget Creation

Two menu tests actively tested the handling of drag and drop within aura's
nested message loop. To do this they set a testing DragDropClient on the root
window by AuraTestHelper.

While this is fine with the classic window server, when being ran as a part of
the views_mus_unittests the WindowTreeClient properly constructs root windows
as needed. This lead to the test having two competiting window trees, and the
test client being installed on the incorrect one.

I've updated the tests to create the full menu/submenu tree, and to install the
DragDropClient on the correct window tree.

TEST=MenuControllerTest.MenuControllerReplacedDuringDrag,
MenuControllerTest.CancelAllDuringDrag
BUG=664280
==========

to

==========
Update MenuControllerTest Widget Creation

Two menu tests actively tested the handling of drag and drop within aura's
nested message loop. To do this they set a testing DragDropClient on the root
window by AuraTestHelper.

While this is fine with the classic window server, when being ran as a part of
the views_mus_unittests the WindowTreeClient properly constructs root windows
as needed. This lead to the test having two competiting window trees, and the
test client being installed on the incorrect one.

I've updated the tests to create the full menu/submenu tree, and to install the
DragDropClient on the correct window tree.

TEST=MenuControllerTest.MenuControllerReplacedDuringDrag,
MenuControllerTest.CancelAllDuringDrag
BUG=664280

Review-Url: https://codereview.chromium.org/2722193003
Cr-Commit-Position: refs/heads/master@{#454259}
Committed:
https://chromium.googlesource.com/chromium/src/+/e0f5db25384b1c70388a90c8c77d...
==========

[commit-bot: I haz the power, 2017-03-02 15:08:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e0f5db25384b1c70388a90c8c77d...