Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2722183005: [Web Payments] Wrap each sheet's content view in a scrollable view. (Closed)

Created:
3 years, 9 months ago by anthonyvd
Modified:
3 years, 9 months ago
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Wrap each sheet's content view in a scrollable view. This change wraps the content of each sheet in a ScrollView so that a scroll bar is displayed when that content is too tall to fit between the dialog header and footer. BUG=697921 Review-Url: https://codereview.chromium.org/2722183005 Cr-Commit-Position: refs/heads/master@{#454613} Committed: https://chromium.googlesource.com/chromium/src/+/44461dddebd225d5be35ef3e86c4c04cf061fe50

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M chrome/browser/ui/views/payments/payment_request_sheet_controller.cc View 2 chunks +15 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
anthonyvd
Hi Math, can you PTAL? Thanks!
3 years, 9 months ago (2017-03-02 16:53:06 UTC) #2
Mathieu
lgtm https://codereview.chromium.org/2722183005/diff/1/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc File chrome/browser/ui/views/payments/payment_sheet_view_controller.cc (right): https://codereview.chromium.org/2722183005/diff/1/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc#newcode187 chrome/browser/ui/views/payments/payment_sheet_view_controller.cc:187: layout->StartRow(0, 0); needs rebase
3 years, 9 months ago (2017-03-02 17:00:13 UTC) #3
anthonyvd
rouslan, can you please do an OWNERs review of this CL? Thanks! https://codereview.chromium.org/2722183005/diff/1/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc File chrome/browser/ui/views/payments/payment_sheet_view_controller.cc ...
3 years, 9 months ago (2017-03-02 18:24:22 UTC) #5
please use gerrit instead
rs lgtm
3 years, 9 months ago (2017-03-03 16:46:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722183005/20001
3 years, 9 months ago (2017-03-03 16:48:22 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 17:46:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/44461dddebd225d5be35ef3e86c4...

Powered by Google App Engine
This is Rietveld 408576698