Switching the no-finch default behavior to enable the blacklist

Changed the default Blacklist case (for no finch)
from disabled to enabled.



BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271246

[csharp, 2014-05-15 18:15:57]

https://codereview.chromium.org/272213006/diff/60001/chrome/browser/chrome_el...
File chrome/browser/chrome_elf_init_unittest_win.cc (right):

https://codereview.chromium.org/272213006/diff/60001/chrome/browser/chrome_el...
chrome/browser/chrome_elf_init_unittest_win.cc:61:
blacklist::BLACKLIST_ENABLED);
This value should be changed to disabled (so we know the initialization actually
changed it)

https://codereview.chromium.org/272213006/diff/60001/chrome/browser/chrome_el...
chrome/browser/chrome_elf_init_unittest_win.cc:65: // all the beacon values set.
nit "all the beacon values set"-> "the blacklist setup."

[krstnmnlsn, 2014-05-15 18:29:59]

https://codereview.chromium.org/272213006/diff/60001/chrome/browser/chrome_el...
File chrome/browser/chrome_elf_init_unittest_win.cc (right):

https://codereview.chromium.org/272213006/diff/60001/chrome/browser/chrome_el...
chrome/browser/chrome_elf_init_unittest_win.cc:61:
blacklist::BLACKLIST_ENABLED);
On 2014/05/15 18:15:58, csharp wrote:
> This value should be changed to disabled (so we know the initialization
actually
> changed it)

Done.

https://codereview.chromium.org/272213006/diff/60001/chrome/browser/chrome_el...
chrome/browser/chrome_elf_init_unittest_win.cc:65: // all the beacon values set.
On 2014/05/15 18:15:58, csharp wrote:
> nit "all the beacon values set"-> "the blacklist setup."

Done.

[csharp, 2014-05-15 18:37:15]

lgtm

[Cait (Slow), 2014-05-15 18:43:19]

drive by comments -- feel free to ignore :)

https://codereview.chromium.org/272213006/diff/80001/chrome/browser/chrome_el...
File chrome/browser/chrome_elf_init_unittest_win.cc (right):

https://codereview.chromium.org/272213006/diff/80001/chrome/browser/chrome_el...
chrome/browser/chrome_elf_init_unittest_win.cc:58:
TEST_F(ChromeBlacklistTrialTest, DefaultRun) {
This looks a lot like the test below it "VerifyFirstRun" now  -- is it worth
adding a test to confirm that users in the "BlacklistDisabled" Finch group are
still having their blacklists disabled (if there are any users in that group any
more)?

[csharp, 2014-05-15 20:09:39]

https://codereview.chromium.org/272213006/diff/80001/chrome/browser/chrome_el...
File chrome/browser/chrome_elf_init_unittest_win.cc (right):

https://codereview.chromium.org/272213006/diff/80001/chrome/browser/chrome_el...
chrome/browser/chrome_elf_init_unittest_win.cc:58:
TEST_F(ChromeBlacklistTrialTest, DefaultRun) {
On 2014/05/15 18:43:19, Cait Phillips wrote:
> This looks a lot like the test below it "VerifyFirstRun" now  -- is it worth
> adding a test to confirm that users in the "BlacklistDisabled" Finch group are
> still having their blacklists disabled (if there are any users in that group
any
> more)?

Yup, that is probably a good idea :)

[krstnmnlsn, 2014-05-16 14:15:03]

https://codereview.chromium.org/272213006/diff/80001/chrome/browser/chrome_el...
File chrome/browser/chrome_elf_init_unittest_win.cc (right):

https://codereview.chromium.org/272213006/diff/80001/chrome/browser/chrome_el...
chrome/browser/chrome_elf_init_unittest_win.cc:58:
TEST_F(ChromeBlacklistTrialTest, DefaultRun) {
On 2014/05/15 20:09:39, csharp wrote:
> On 2014/05/15 18:43:19, Cait Phillips wrote:
> > This looks a lot like the test below it "VerifyFirstRun" now  -- is it worth
> > adding a test to confirm that users in the "BlacklistDisabled" Finch group
are
> > still having their blacklists disabled (if there are any users in that group
> any
> > more)?
> 
> Yup, that is probably a good idea :)

Done.

[csharp, 2014-05-16 18:35:14]

https://codereview.chromium.org/272213006/diff/100001/chrome/browser/chrome_e...
File chrome/browser/chrome_elf_init_unittest_win.cc (right):

https://codereview.chromium.org/272213006/diff/100001/chrome/browser/chrome_e...
chrome/browser/chrome_elf_init_unittest_win.cc:83: // Set some dummy values as
beacons.
These are enabled values, not dummy values

https://codereview.chromium.org/272213006/diff/100001/chrome/browser/chrome_e...
chrome/browser/chrome_elf_init_unittest_win.cc:88: // Create the field trial
with the Blacklist disabled group
nit: Blacklist -> blacklist, missing .

https://codereview.chromium.org/272213006/diff/100001/chrome/browser/chrome_e...
chrome/browser/chrome_elf_init_unittest_win.cc:96: // This setup code should now
delete any existing blacklist beacons
nit: missing .

https://codereview.chromium.org/272213006/diff/100001/chrome/browser/chrome_e...
File chrome/browser/chrome_elf_init_win.h (right):

https://codereview.chromium.org/272213006/diff/100001/chrome/browser/chrome_e...
chrome/browser/chrome_elf_init_win.h:8: // Field Trial name and full name for
the blacklist disabled group
Nit: Trial -> trial and missing period at the end of the line (all comments must
be full sentences)

[krstnmnlsn, 2014-05-16 20:37:08]

https://codereview.chromium.org/272213006/diff/100001/chrome/browser/chrome_e...
File chrome/browser/chrome_elf_init_unittest_win.cc (right):

https://codereview.chromium.org/272213006/diff/100001/chrome/browser/chrome_e...
chrome/browser/chrome_elf_init_unittest_win.cc:83: // Set some dummy values as
beacons.
On 2014/05/16 18:35:14, csharp wrote:
> These are enabled values, not dummy values

Done.

https://codereview.chromium.org/272213006/diff/100001/chrome/browser/chrome_e...
chrome/browser/chrome_elf_init_unittest_win.cc:88: // Create the field trial
with the Blacklist disabled group
On 2014/05/16 18:35:14, csharp wrote:
> nit: Blacklist -> blacklist, missing .

Done.

https://codereview.chromium.org/272213006/diff/100001/chrome/browser/chrome_e...
chrome/browser/chrome_elf_init_unittest_win.cc:96: // This setup code should now
delete any existing blacklist beacons
On 2014/05/16 18:35:14, csharp wrote:
> nit: missing .

Done.

https://codereview.chromium.org/272213006/diff/100001/chrome/browser/chrome_e...
File chrome/browser/chrome_elf_init_win.h (right):

https://codereview.chromium.org/272213006/diff/100001/chrome/browser/chrome_e...
chrome/browser/chrome_elf_init_win.h:8: // Field Trial name and full name for
the blacklist disabled group
On 2014/05/16 18:35:14, csharp wrote:
> Nit: Trial -> trial and missing period at the end of the line (all comments
must
> be full sentences)

Done.

[csharp, 2014-05-16 20:48:37]

lgtm

[krstnmnlsn, 2014-05-16 20:48:54]

The CQ bit was checked by krstnmnlsn@chromium.org

[commit-bot: I haz the power, 2014-05-16 20:49:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/krstnmnlsn@chromium.org/272213006/120001

[commit-bot: I haz the power, 2014-05-17 06:45:05]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-17 17:35:24]

Change committed as 271246