chrome/browser/chrome_elf_init_win.h - Issue 272213006: Switching the no-finch default behavior to enable the blacklist

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chrome_elf_init_win.h

Issue 272213006: Switching the no-finch default behavior to enable the blacklist (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added BlackListDisabledRun to chrome_elf_init_unittest_win.cc Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/chrome_elf_init_unittest_win.cc ('K') | « chrome/browser/chrome_elf_init_unittest_win.cc ('k') | chrome/browser/chrome_elf_init_win.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_	5 #ifndef CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_

6 #define CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_	6 #define CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_

7	7

	8 // Field Trial name and full name for the blacklist disabled group
	csharp 2014/05/16 18:35:14 Nit: Trial -> trial and missing period at the end Nit: Trial -> trial and missing period at the end of the line (all comments must be full sentences) krstnmnlsn 2014/05/16 20:37:08 Done. Show quoted text On 2014/05/16 18:35:14, csharp wrote: > Nit: Trial -> trial and missing period at the end of the line (all comments must > be full sentences) Done.
	9 extern const char kBrowserBlacklistTrialName[];

	10 extern const char kBrowserBlacklistTrialDisabledGroupName[];

	11

8 // Prepare any initialization code for Chrome Elf's setup (This will generally	12 // Prepare any initialization code for Chrome Elf's setup (This will generally

9 // only affect future runs since Chrome Elf is already setup by this point).	13 // only affect future runs since Chrome Elf is already setup by this point).

10 void InitializeChromeElf();	14 void InitializeChromeElf();

11	15

12 // Set the required state for an enabled browser blacklist.	16 // Set the required state for an enabled browser blacklist.

13 void BrowserBlacklistBeaconSetup();	17 void BrowserBlacklistBeaconSetup();

14	18

15 #endif // CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_	19 #endif // CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_

OLD	NEW