Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2722113007: Disable the passthrough touch event queue for now. (Closed)

Created:
3 years, 9 months ago by dtapuska
Modified:
3 years, 9 months ago
Reviewers:
tdresser
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable the passthrough touch event queue for now. Due to perf regressions disable the passthrough touch event queue it causes GestureScrollUpdate events to take more time. BUG=697871, 642368 Review-Url: https://codereview.chromium.org/2722113007 Cr-Commit-Position: refs/heads/master@{#454504} Committed: https://chromium.googlesource.com/chromium/src/+/abf462cdff2f095ab1ab69beb78c8b658bfb634a

Patch Set 1 #

Patch Set 2 : Fix failing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M content/browser/renderer_host/input/input_router_impl.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 25 (17 generated)
dtapuska
3 years, 9 months ago (2017-03-02 21:26:09 UTC) #4
tdresser
LGTM, thanks.
3 years, 9 months ago (2017-03-02 21:30:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722113007/1
3 years, 9 months ago (2017-03-02 21:34:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/25828)
3 years, 9 months ago (2017-03-02 21:50:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722113007/1
3 years, 9 months ago (2017-03-03 02:03:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/320498)
3 years, 9 months ago (2017-03-03 02:27:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722113007/20001
3 years, 9 months ago (2017-03-03 03:19:39 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 03:47:43 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/abf462cdff2f095ab1ab69beb78c...

Powered by Google App Engine
This is Rietveld 408576698