Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2722113006: Revert of Introduce SchedulerSingleThreadTaskRunnerManager (Closed)

Created:
3 years, 9 months ago by Theresa
Modified:
3 years, 9 months ago
Reviewers:
robliao, gab, fdoray
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce SchedulerSingleThreadTaskRunnerManager (patchset #7 id:280001 of https://codereview.chromium.org/2698843006/ ) Reason for revert: TaskSchedulerSingleThreadTaskRunnerManagerTest.PrioritySetCorrectly is failing on numerous bots. See crbug.com/697697 Original issue's description: > Introduce SchedulerSingleThreadTaskRunnerManager > > This component provides one dedicated thread per > SingleThreadTaskRunner. > > Reference Change: > https://codereview.chromium.org/2686593003/ > > BUG=684080, 694823 > > Review-Url: https://codereview.chromium.org/2698843006 > Cr-Commit-Position: refs/heads/master@{#453162} > Committed: https://chromium.googlesource.com/chromium/src/+/fc203f52e046a8d82e053525d764671f7128f3d4 TBR=gab@chromium.org,fdoray@chromium.org,robliao@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=684080, 694823, 697697 Review-Url: https://codereview.chromium.org/2722113006 Cr-Commit-Position: refs/heads/master@{#454346} Committed: https://chromium.googlesource.com/chromium/src/+/78d29d2505c18c37f2869bcca08cf18701892655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -648 lines) Patch
M base/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D base/task_scheduler/scheduler_single_thread_task_runner_manager.h View 1 chunk +0 lines, -68 lines 0 comments Download
D base/task_scheduler/scheduler_single_thread_task_runner_manager.cc View 1 chunk +0 lines, -274 lines 0 comments Download
D base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc View 1 chunk +0 lines, -254 lines 0 comments Download
M base/task_scheduler/scheduler_worker_pool_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/task_scheduler/scheduler_worker_pool_params.h View 3 chunks +5 lines, -2 lines 0 comments Download
M base/task_scheduler/scheduler_worker_pool_params.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl_unittest.cc View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Theresa
Created Revert of Introduce SchedulerSingleThreadTaskRunnerManager
3 years, 9 months ago (2017-03-02 18:44:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722113006/1
3 years, 9 months ago (2017-03-02 18:45:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/78d29d2505c18c37f2869bcca08cf18701892655
3 years, 9 months ago (2017-03-02 19:46:06 UTC) #7
robliao
3 years, 9 months ago (2017-03-03 04:56:53 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698