Flush UKM metrics when backgrounded on Android and iOS.

Flush UKM metrics when backgrounded on Android and iOS.

BUG=697632
Review-Url: https://codereview.chromium.org/2722113004
Cr-Commit-Position: refs/heads/master@{#454242}
Committed: https://chromium.googlesource.com/chromium/src/+/919ff542cdde626f265f87cb8888a1a9d88bd797

[Bryan McQuade, 2017-03-01 22:03:03]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 22:04:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 22:07:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 22:07:22]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bryan McQuade, 2017-03-01 22:15:32]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 22:15:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-03-01 22:22:17]

bmcquade@chromium.org changed reviewers:
+ holte@chromium.org

[Bryan McQuade, 2017-03-01 22:23:11]

Hi Steven,

Here's a basic implementation that hooks into the app start/stop flow on
Android, to persist UKM data when we go into the background. Let me know what
you think. Thanks!

[Steven Holte, 2017-03-01 22:26:42]

lgtm

[Bryan McQuade, 2017-03-01 22:31:05]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 22:31:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-03-01 22:34:41]

bmcquade@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Bryan McQuade, 2017-03-01 22:35:56]

Description was changed from

==========
Flush UKM metrics when backgrounded on Android.

BUG=
==========

to

==========
Flush UKM metrics when backgrounded on Android and iOS.

BUG=697632
==========

[Bryan McQuade, 2017-03-01 22:36:39]

asvitkine, PTAL, thanks!

[commit-bot: I haz the power, 2017-03-01 22:41:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 22:41:02]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Alexei Svitkine (slow), 2017-03-01 22:56:13]

https://codereview.chromium.org/2722113004/diff/40001/chrome/browser/android/...
File chrome/browser/android/metrics/uma_session_stats.cc (right):

https://codereview.chromium.org/2722113004/diff/40001/chrome/browser/android/...
chrome/browser/android/metrics/uma_session_stats.cc:58: if (ukm_service) {
Nit: No {}s

Remove them from metrics service case above and below as well.

https://codereview.chromium.org/2722113004/diff/40001/components/ukm/ukm_serv...
File components/ukm/ukm_service.cc (right):

https://codereview.chromium.org/2722113004/diff/40001/components/ukm/ukm_serv...
components/ukm/ukm_service.cc:206: if (!initialize_started_)
Can you add a comment about this case?

[Bryan McQuade, 2017-03-01 23:06:03]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 23:06:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-03-01 23:06:51]

Addressed comments. PTAL, thanks!

https://codereview.chromium.org/2722113004/diff/40001/chrome/browser/android/...
File chrome/browser/android/metrics/uma_session_stats.cc (right):

https://codereview.chromium.org/2722113004/diff/40001/chrome/browser/android/...
chrome/browser/android/metrics/uma_session_stats.cc:58: if (ukm_service) {
On 2017/03/01 at 22:56:13, Alexei Svitkine (slow) wrote:
> Nit: No {}s
> 
> Remove them from metrics service case above and below as well.

Done

https://codereview.chromium.org/2722113004/diff/40001/components/ukm/ukm_serv...
File components/ukm/ukm_service.cc (right):

https://codereview.chromium.org/2722113004/diff/40001/components/ukm/ukm_serv...
components/ukm/ukm_service.cc:206: if (!initialize_started_)
On 2017/03/01 at 22:56:13, Alexei Svitkine (slow) wrote:
> Can you add a comment about this case?

Done

[Bryan McQuade, 2017-03-01 23:08:54]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 23:09:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 23:19:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 23:19:29]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Alexei Svitkine (slow), 2017-03-01 23:24:02]

lgtm

https://codereview.chromium.org/2722113004/diff/80001/components/ukm/ukm_serv...
File components/ukm/ukm_service.cc (right):

https://codereview.chromium.org/2722113004/diff/80001/components/ukm/ukm_serv...
components/ukm/ukm_service.cc:206: // If initialize_started_ is false, UKM has
not yet been started, so bail.
Nit: Mention that the scheduler will instead be started via EnableReporting().

[Bryan McQuade, 2017-03-01 23:30:19]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 23:30:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-03-01 23:37:11]

https://codereview.chromium.org/2722113004/diff/80001/components/ukm/ukm_serv...
File components/ukm/ukm_service.cc (right):

https://codereview.chromium.org/2722113004/diff/80001/components/ukm/ukm_serv...
components/ukm/ukm_service.cc:206: // If initialize_started_ is false, UKM has
not yet been started, so bail.
On 2017/03/01 at 23:24:02, Alexei Svitkine (slow) wrote:
> Nit: Mention that the scheduler will instead be started via EnableReporting().

sure, done, thanks!

[Bryan McQuade, 2017-03-01 23:38:54]

bmcquade@chromium.org changed reviewers:
+ droger@chromium.org

[Bryan McQuade, 2017-03-01 23:39:09]

droger, PTAL for ios/chrome changes, thanks!

[commit-bot: I haz the power, 2017-03-02 00:59:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 00:59:09]

Dry run: This issue passed the CQ dry run.

[droger, 2017-03-02 09:59:42]

lgtm

[Bryan McQuade, 2017-03-02 13:00:41]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2017-03-02 13:00:42]

The patchset sent to the CQ was uploaded after l-g-t-m from holte@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2722113004/#ps120001
(title: "address comment")

[commit-bot: I haz the power, 2017-03-02 13:00:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 13:05:55]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1488459641648700,
"parent_rev": "a8be5d4dabe8587567639e63831e3fc74ee089c2", "commit_rev":
"919ff542cdde626f265f87cb8888a1a9d88bd797"}

[commit-bot: I haz the power, 2017-03-02 13:06:30]

Description was changed from

==========
Flush UKM metrics when backgrounded on Android and iOS.

BUG=697632
==========

to

==========
Flush UKM metrics when backgrounded on Android and iOS.

BUG=697632

Review-Url: https://codereview.chromium.org/2722113004
Cr-Commit-Position: refs/heads/master@{#454242}
Committed:
https://chromium.googlesource.com/chromium/src/+/919ff542cdde626f265f87cb8888...
==========

[commit-bot: I haz the power, 2017-03-02 13:06:31]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/919ff542cdde626f265f87cb8888...