Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2722073002: GPU VSync: add timer based v-sync as a backup mechanism for when display goes to sleep. (Closed)

Created:
3 years, 9 months ago by stanisc
Modified:
3 years, 9 months ago
Reviewers:
jbauman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GPU VSync: add timer based v-sync as a backup mechanism for when display goes to sleep. When display goes to sleep GPU v-sync is no longer available - D3D calls that waits for v-blank returns with STATUS_GRAPHICS_PRESENT_OCCLUDED error. This change adds a backup mechanism which posts a delayed task to wait for the next expected v-sync. BUG=467617 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2722073002 Cr-Commit-Position: refs/heads/master@{#454095} Committed: https://chromium.googlesource.com/chromium/src/+/3fb710b34693d9e9917a3c60367bae9798845b1c

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : Removed empty line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -23 lines) Patch
M gpu/ipc/service/gpu_vsync_provider_win.cc View 1 2 8 chunks +60 lines, -23 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
stanisc
PTAL!
3 years, 9 months ago (2017-03-01 19:12:52 UTC) #10
jbauman
lgtm
3 years, 9 months ago (2017-03-01 22:33:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722073002/40001
3 years, 9 months ago (2017-03-01 22:43:01 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/3fb710b34693d9e9917a3c60367bae9798845b1c
3 years, 9 months ago (2017-03-01 23:42:13 UTC) #19
RE66
3 years, 9 months ago (2017-03-02 04:42:22 UTC) #20
Message was sent while issue was closed.
On 2017/03/01 23:42:13, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
>
https://chromium.googlesource.com/chromium/src/+/3fb710b34693d9e9917a3c60367b...

I think you should wait for screen wakeup event and not busy waiting

Powered by Google App Engine
This is Rietveld 408576698