Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2722013002: Use custom user data to serialize Tab last visited timestamp. (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 9 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, marq+watch_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use custom user data to serialize Tab last visited timestamp. The Tab last visited timestamp is not used in ios/web/ so remove it from CRWSessionController and instead move it to custom user data in CRWSessionStorage. BUG=None Review-Url: https://codereview.chromium.org/2722013002 Cr-Commit-Position: refs/heads/master@{#453956} Committed: https://chromium.googlesource.com/chromium/src/+/8467aba28632c47f30270cd3d5bf32e5f07ae255

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -38 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 3 chunks +19 lines, -8 lines 0 comments Download
M ios/web/navigation/crw_session_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 6 chunks +8 lines, -16 lines 0 comments Download
M ios/web/navigation/crw_session_storage_unittest.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/web/navigation/serializable_user_data_manager_impl.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/web/navigation/session_storage_builder.mm View 2 chunks +0 lines, -3 lines 0 comments Download
M ios/web/public/crw_session_storage.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/public/crw_session_storage.mm View 4 chunks +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
sdefresne
Please take a look.
3 years, 9 months ago (2017-02-28 23:11:36 UTC) #3
kkhorimoto
lgtm
3 years, 9 months ago (2017-02-28 23:55:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722013002/20001
3 years, 9 months ago (2017-03-01 16:58:07 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 17:04:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8467aba28632c47f30270cd3d5bf...

Powered by Google App Engine
This is Rietveld 408576698