Omnibox - Make Clipboard Provider Enabled via an Experimental Feature

Omnibox - Make Clipboard Provider Enabled via an Experimental Feature

In the process, revise the list of default providers from a built-in
const to something that's determined dynamically when the omnibox system
is created.

The only interesting part of this changelist is in
components/omnibox/browser/autocomplete_classifier.{h,cc}

Pretty much everything else is downstream changes due to changing an interface.

TBR=mariakhomenko,rohitrao
mariakhomenko for trivial change in chrome/browser/android/omnibox/
rohitrao for trivial change in ios/chrome/browser/autocomplete/

BUG=642114
Review-Url: https://codereview.chromium.org/2721993002
Cr-Commit-Position: refs/heads/master@{#454035}
Committed: https://chromium.googlesource.com/chromium/src/+/612b3dc0d5ab6aaf839cc33e71d5e4f1e49e2bf8

[Mark P, 2017-02-28 23:00:47]

Description was changed from

==========
Omnibox - Make Clipboard Provider Enabled via an Experimental Feature

In the process, revise the list of default providers from a built-in
const to something that's determined dynamically when the omnibox system
is created.

BUG=642114
==========

to

==========
Omnibox - Make Clipboard Provider Enabled via an Experimental Feature

In the process, revise the list of default providers from a built-in
const to something that's determined dynamically when the omnibox system
is created.

The only interesting part of this changelist is in
components/omnibox/browser/autocomplete_classifier.{h,cc}

Pretty much everything else is downstream changes due to changing an interface.

BUG=642114
==========

[Mark P, 2017-02-28 23:06:01]

mpearson@chromium.org changed reviewers:
+ pkasting@chromium.org

[Mark P, 2017-02-28 23:06:02]

Hey Peter,

This is not urgent.  Please do at your leisure.

It should be straightforward.

thanks,
mark

https://codereview.chromium.org/2721993002/diff/20001/components/omnibox/brow...
File components/omnibox/browser/autocomplete_classifier.h (right):

https://codereview.chromium.org/2721993002/diff/20001/components/omnibox/brow...
components/omnibox/browser/autocomplete_classifier.h:26: static int
DefaultOmniboxProviders();
TODO(mpearson): after review, move this down to line 36 (i.e., just below
Shutdown()) and move the implementation correspondingly.  I left it in the
current place for the moment to make this easier to review.

[Peter Kasting, 2017-03-01 02:47:14]

LGTM

[Mark P, 2017-03-01 05:10:38]

Description was changed from

==========
Omnibox - Make Clipboard Provider Enabled via an Experimental Feature

In the process, revise the list of default providers from a built-in
const to something that's determined dynamically when the omnibox system
is created.

The only interesting part of this changelist is in
components/omnibox/browser/autocomplete_classifier.{h,cc}

Pretty much everything else is downstream changes due to changing an interface.

BUG=642114
==========

to

==========
Omnibox - Make Clipboard Provider Enabled via an Experimental Feature

In the process, revise the list of default providers from a built-in
const to something that's determined dynamically when the omnibox system
is created.

The only interesting part of this changelist is in
components/omnibox/browser/autocomplete_classifier.{h,cc}

Pretty much everything else is downstream changes due to changing an interface.

TBR=mariakhomenko
mariakhomenko for trivial change in chrome/browser/android/omnibox/

BUG=642114
==========

[Mark P, 2017-03-01 05:10:55]

The CQ bit was checked by mpearson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 05:11:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 05:20:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 05:20:23]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Mark P, 2017-03-01 05:24:33]

Description was changed from

==========
Omnibox - Make Clipboard Provider Enabled via an Experimental Feature

In the process, revise the list of default providers from a built-in
const to something that's determined dynamically when the omnibox system
is created.

The only interesting part of this changelist is in
components/omnibox/browser/autocomplete_classifier.{h,cc}

Pretty much everything else is downstream changes due to changing an interface.

TBR=mariakhomenko
mariakhomenko for trivial change in chrome/browser/android/omnibox/

BUG=642114
==========

to

==========
Omnibox - Make Clipboard Provider Enabled via an Experimental Feature

In the process, revise the list of default providers from a built-in
const to something that's determined dynamically when the omnibox system
is created.

The only interesting part of this changelist is in
components/omnibox/browser/autocomplete_classifier.{h,cc}

Pretty much everything else is downstream changes due to changing an interface.

TBR=mariakhomenko,rohitrao
mariakhomenko for trivial change in chrome/browser/android/omnibox/
rohitrao for trivial change in ios/chrome/browser/autocomplete/

BUG=642114
==========

[Mark P, 2017-03-01 05:24:42]

The CQ bit was checked by mpearson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 05:25:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 05:54:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 05:55:00]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Justin Donnelly, 2017-03-01 14:51:35]

jdonnelly@chromium.org changed reviewers:
+ jdonnelly@chromium.org

[Justin Donnelly, 2017-03-01 14:51:36]

https://codereview.chromium.org/2721993002/diff/60001/components/omnibox/brow...
File components/omnibox/browser/autocomplete_classifier.cc (right):

https://codereview.chromium.org/2721993002/diff/60001/components/omnibox/brow...
components/omnibox/browser/autocomplete_classifier.cc:52:
(base::FeatureList::IsEnabled(omnibox::kEnableClipboardProvider)
Shouldn't this still be default enabled on iOS?

[Mark P, 2017-03-01 18:20:31]

https://codereview.chromium.org/2721993002/diff/60001/components/omnibox/brow...
File components/omnibox/browser/autocomplete_classifier.cc (right):

https://codereview.chromium.org/2721993002/diff/60001/components/omnibox/brow...
components/omnibox/browser/autocomplete_classifier.cc:52:
(base::FeatureList::IsEnabled(omnibox::kEnableClipboardProvider)
On 2017/03/01 14:51:36, Justin Donnelly wrote:
> Shouldn't this still be default enabled on iOS?

Yes, it is.  See components/omnibox/browser/omnibox_field_trial.cc

It's now just under feature flag control.

[Mark P, 2017-03-01 18:22:59]

The CQ bit was checked by mpearson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 18:23:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 18:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 18:26:17]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mark P, 2017-03-01 20:15:24]

The CQ bit was checked by mpearson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 20:16:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 21:15:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 21:15:22]

Dry run: This issue passed the CQ dry run.

[Mark P, 2017-03-01 21:16:55]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2017-03-01 21:16:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2721993002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-01 21:17:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 21:24:02]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488403015742290,
"parent_rev": "f99f337e2d20e41f24b53ebb266ff683621da37e", "commit_rev":
"612b3dc0d5ab6aaf839cc33e71d5e4f1e49e2bf8"}

[commit-bot: I haz the power, 2017-03-01 21:24:42]

Description was changed from

==========
Omnibox - Make Clipboard Provider Enabled via an Experimental Feature

In the process, revise the list of default providers from a built-in
const to something that's determined dynamically when the omnibox system
is created.

The only interesting part of this changelist is in
components/omnibox/browser/autocomplete_classifier.{h,cc}

Pretty much everything else is downstream changes due to changing an interface.

TBR=mariakhomenko,rohitrao
mariakhomenko for trivial change in chrome/browser/android/omnibox/
rohitrao for trivial change in ios/chrome/browser/autocomplete/

BUG=642114
==========

to

==========
Omnibox - Make Clipboard Provider Enabled via an Experimental Feature

In the process, revise the list of default providers from a built-in
const to something that's determined dynamically when the omnibox system
is created.

The only interesting part of this changelist is in
components/omnibox/browser/autocomplete_classifier.{h,cc}

Pretty much everything else is downstream changes due to changing an interface.

TBR=mariakhomenko,rohitrao
mariakhomenko for trivial change in chrome/browser/android/omnibox/
rohitrao for trivial change in ios/chrome/browser/autocomplete/

BUG=642114

Review-Url: https://codereview.chromium.org/2721993002
Cr-Commit-Position: refs/heads/master@{#454035}
Committed:
https://chromium.googlesource.com/chromium/src/+/612b3dc0d5ab6aaf839cc33e71d5...
==========

[commit-bot: I haz the power, 2017-03-01 21:24:43]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/612b3dc0d5ab6aaf839cc33e71d5...