Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2721983002:
Stop using undocumented _THROW0() macro (Closed)
DescriptionStop using undocumented _THROW0() macro
Billy O'Neal at Microsoft mentioned people depend on this undocumented
macro. Bruce Dawson at Google noticed we use it in Chrome.
Context: https://twitter.com/BruceDawson0xB/status/836700784947441664
BUG=697216
Review-Url: https://codereview.chromium.org/2721983002
Cr-Commit-Position: refs/heads/master@{#458213}
Committed: https://chromium.googlesource.com/chromium/src/+/0bf02bd5b61add98b21b51c184579e15ecc49c45
Patch Set 1 #Patch Set 2 : Rebasing #Patch Set 3 : Update existing code in area to reflect style guide #Patch Set 4 : Remove noexcept -- warns in VC without an exception handling mode #
Total comments: 2
Patch Set 5 : Separate zeroing pixel data from setting alpha #Patch Set 6 : That last PS was not supposed to be on this CR #Patch Set 7 : Fixing accidental patch set #Messages
Total messages: 28 (21 generated)
The CQ bit was checked by cblume@chromium.org to run a CQ dry run
Description was changed from ========== Stop using undocumented _THROW0() macro Billy O'Neal at Microsoft mentioned people depend on this undocumented macro. Bruce Dawson at Google noticed we use it in Chrome. BUG=697216 ========== to ========== Stop using undocumented _THROW0() macro Billy O'Neal at Microsoft mentioned people depend on this undocumented macro. Bruce Dawson at Google noticed we use it in Chrome. https://twitter.com/BruceDawson0xB/status/836700784947441664 BUG=697216 ==========
cblume@chromium.org changed reviewers: + brucedawson@chromium.org, tommi@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Stop using undocumented _THROW0() macro Billy O'Neal at Microsoft mentioned people depend on this undocumented macro. Bruce Dawson at Google noticed we use it in Chrome. https://twitter.com/BruceDawson0xB/status/836700784947441664 BUG=697216 ========== to ========== Stop using undocumented _THROW0() macro Billy O'Neal at Microsoft mentioned people depend on this undocumented macro. Bruce Dawson at Google noticed we use it in Chrome. Context: https://twitter.com/BruceDawson0xB/status/836700784947441664 BUG=697216 ==========
The CQ bit was checked by cblume@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by cblume@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
PTAL
lgtm
https://codereview.chromium.org/2721983002/diff/60001/courgette/memory_alloca... File courgette/memory_allocator.h (right): https://codereview.chromium.org/2721983002/diff/60001/courgette/memory_alloca... courgette/memory_allocator.h:154: class MemoryAllocator { actually... is there a difference now between the windows and non-windows implementation? If not, can we reduce the duplication?
https://codereview.chromium.org/2721983002/diff/60001/courgette/memory_alloca... File courgette/memory_allocator.h (right): https://codereview.chromium.org/2721983002/diff/60001/courgette/memory_alloca... courgette/memory_allocator.h:154: class MemoryAllocator { On 2017/03/03 08:32:33, tommi - chröme wrote: > actually... is there a difference now between the windows and non-windows > implementation? > If not, can we reduce the duplication? It looks like there is a difference. On Mac & Linux allocation happens on the heap. On Windows allocation happens on either the heap or a file. The file acts as a page file that is only available to Chrome.
On 2017/03/06 21:25:45, cblume wrote: > https://codereview.chromium.org/2721983002/diff/60001/courgette/memory_alloca... > File courgette/memory_allocator.h (right): > > https://codereview.chromium.org/2721983002/diff/60001/courgette/memory_alloca... > courgette/memory_allocator.h:154: class MemoryAllocator { > On 2017/03/03 08:32:33, tommi - chröme wrote: > > actually... is there a difference now between the windows and non-windows > > implementation? > > If not, can we reduce the duplication? > > It looks like there is a difference. > On Mac & Linux allocation happens on the heap. > On Windows allocation happens on either the heap or a file. > The file acts as a page file that is only available to Chrome. Sorry, Patch Set 5 was supposed to land as a completely separate issue. I'm not sure why it ended up here. I'll create a Patch Set 6 to undo that.
The CQ bit was checked by cblume@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by cblume@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org Link to the patchset: https://codereview.chromium.org/2721983002/#ps120001 (title: "Fixing accidental patch set")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490049454037720,
"parent_rev": "9666552a7d57ef22325941a387f178de2617d959", "commit_rev":
"0bf02bd5b61add98b21b51c184579e15ecc49c45"}
Message was sent while issue was closed.
Description was changed from ========== Stop using undocumented _THROW0() macro Billy O'Neal at Microsoft mentioned people depend on this undocumented macro. Bruce Dawson at Google noticed we use it in Chrome. Context: https://twitter.com/BruceDawson0xB/status/836700784947441664 BUG=697216 ========== to ========== Stop using undocumented _THROW0() macro Billy O'Neal at Microsoft mentioned people depend on this undocumented macro. Bruce Dawson at Google noticed we use it in Chrome. Context: https://twitter.com/BruceDawson0xB/status/836700784947441664 BUG=697216 Review-Url: https://codereview.chromium.org/2721983002 Cr-Commit-Position: refs/heads/master@{#458213} Committed: https://chromium.googlesource.com/chromium/src/+/0bf02bd5b61add98b21b51c18457... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/0bf02bd5b61add98b21b51c18457... |
