Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2721953003:
Makes mojo generator generate export for constants (Closed)
|
Created:
3 years, 9 months ago by sky Modified:
3 years, 9 months ago Reviewers:
yzshen1 CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMakes mojo generator generate export for constants
This is necessary in component builds otherwise you get link errors.
BUG=697206
TEST=none, but I'll soon land a mojom that uses this
R=yzshen@chromium.org
Review-Url: https://codereview.chromium.org/2721953003
Cr-Commit-Position: refs/heads/master@{#453854}
Committed: https://chromium.googlesource.com/chromium/src/+/94a9748c19572dbed81486360ff37d778d86c421
Patch Set 1 #
Total comments: 2
Patch Set 2 : global #Messages
Total messages: 18 (10 generated)
The CQ bit was checked by sky@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2721953003/diff/1/mojo/public/tools/bindings/... File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right): https://codereview.chromium.org/2721953003/diff/1/mojo/public/tools/bindings/... mojo/public/tools/bindings/generators/mojom_cpp_generator.py:219: def FormatConstantDeclaration(constant, nested=False, export_attribute=None): Instead of having an export_attribute input, how about defining a global variable _export_attribute similar to _for_blink and others?
https://codereview.chromium.org/2721953003/diff/1/mojo/public/tools/bindings/... File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right): https://codereview.chromium.org/2721953003/diff/1/mojo/public/tools/bindings/... mojo/public/tools/bindings/generators/mojom_cpp_generator.py:219: def FormatConstantDeclaration(constant, nested=False, export_attribute=None): On 2017/02/28 23:13:09, yzshen1 wrote: > Instead of having an export_attribute input, how about defining a global > variable _export_attribute similar to _for_blink and others? Done.
The CQ bit was checked by sky@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/02/28 23:45:04, sky wrote: > https://codereview.chromium.org/2721953003/diff/1/mojo/public/tools/bindings/... > File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right): > > https://codereview.chromium.org/2721953003/diff/1/mojo/public/tools/bindings/... > mojo/public/tools/bindings/generators/mojom_cpp_generator.py:219: def > FormatConstantDeclaration(constant, nested=False, export_attribute=None): > On 2017/02/28 23:13:09, yzshen1 wrote: > > Instead of having an export_attribute input, how about defining a global > > variable _export_attribute similar to _for_blink and others? > > Done. LGTM
The CQ bit was unchecked by sky@chromium.org
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488341433991410,
"parent_rev": "7ff96ffaec996e51a13ac4b9f026d96f81910348", "commit_rev":
"94a9748c19572dbed81486360ff37d778d86c421"}
Message was sent while issue was closed.
Description was changed from ========== Makes mojo generator generate export for constants This is necessary in component builds otherwise you get link errors. BUG=697206 TEST=none, but I'll soon land a mojom that uses this R=yzshen@chromium.org ========== to ========== Makes mojo generator generate export for constants This is necessary in component builds otherwise you get link errors. BUG=697206 TEST=none, but I'll soon land a mojom that uses this R=yzshen@chromium.org Review-Url: https://codereview.chromium.org/2721953003 Cr-Commit-Position: refs/heads/master@{#453854} Committed: https://chromium.googlesource.com/chromium/src/+/94a9748c19572dbed81486360ff3... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/94a9748c19572dbed81486360ff3... |
